Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.1 Intersection Types Support for function Return Type #34932

Open
karyna-tsymbal-atwix opened this issue Jan 5, 2022 · 3 comments
Open

Comments

@karyna-tsymbal-atwix
Copy link
Contributor

karyna-tsymbal-atwix commented Jan 5, 2022

In PHP 8.1, new Intersection types feature was introduced.
(see details https://wiki.php.net/rfc/pure-intersection-types)

e.g. it's possible to create a function with a signature like
function something(): Foo&Bar&Baz { ...
were return type is an intersection.

Right now Magento will not work properly with such a feature. There are several places where we're using return type's Class (e.g. for code generation):

Such places should be adjusted to work properly with intersection types.
The main reason for this adjustments it's because 3rd-party developers may develop some new extensions and declare them to support only php >= 8.1.
in such modules they may use this PHP8.1-feature.

Expected result (*)

Magento should not break when Intersection types are used in the function return type. It should properly generate code and so on.

Actual result (*)

Right now Magento can't handle Intersection types introduced in php 8.1

Related issues:

#34931
#34933

Note: There is a Union type feature that should also be implemented. Need to make sure that 2 people do not work on these features in parallel, as this will lead to a conflict!
#34264

@m2-assistant
Copy link

m2-assistant bot commented Jan 5, 2022

Hi @karyna-tsymbal-atwix. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Dec 14, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link

Hi @karyna-tsymbal-atwix ,
We have gone through the main description and found that this is not related to any bug of Magento but it can be a good feature to have in Magento. Hence marking this ticket as a feature request to process further.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Feature Requests Backlog
  
Ready for Grooming
Development

No branches or pull requests

4 participants