Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Upload SVG Logo #35125

Open
4 tasks
Stoyvo opened this issue Feb 20, 2022 · 10 comments
Open
4 tasks

Cannot Upload SVG Logo #35125

Stoyvo opened this issue Feb 20, 2022 · 10 comments
Assignees
Labels
Area: Admin UI Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@Stoyvo
Copy link

Stoyvo commented Feb 20, 2022

Preconditions (*)

  1. Read official Magento Documentation (https://docs.magento.com/user-guide/design/logo-upload.html)
  2. Have SVG image

Steps to reproduce (*)

  1. In Admin, Navigate to Content -> Theme Configuration -> Select Theme
  2. Open Header section
  3. Select .svg image for Logo

Expected result (*)

  1. Upload image as SVG

Actual result (*)

Error: "We don't recognize or support this file extension type."


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [*] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Feb 20, 2022

Hi @Stoyvo. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@Stoyvo
Copy link
Author

Stoyvo commented Feb 20, 2022

Upon research, I have identified that Magento removed SVG support in 2017?
#12451

I find this hard to believe, otherwise official documentation would have been updated right? Official documentation specifically instructs user to select SVG file.

In addition, SVG is the preferred image format for scaling images in web best practices.

@engcom-Delta engcom-Delta self-assigned this Feb 21, 2022
@m2-assistant
Copy link

m2-assistant bot commented Feb 21, 2022

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta engcom-Delta added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Issue: ready for confirmation labels Feb 21, 2022
@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Feb 21, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Feb 21, 2022
@github-jira-sync-bot
Copy link

❌ Something went wrong. Cannot create Jira issue.

@engcom-Delta engcom-Delta added Area: Admin UI and removed Area: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 21, 2022
@m2-community-project m2-community-project bot moved this from Confirmed to Ready for Confirmation in Issue Confirmation and Triage Board Feb 21, 2022
@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Feb 21, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Feb 21, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Feb 21, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-2438 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Feb 21, 2022

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Delta
Copy link
Contributor

Hi @Stoyvo ,
Thank you for reporting the issue. We have verified the issue on Magento 2.4-develop branch and the issue is reproducible.
Based on the above observation, confirming the issue.

Steps Performed:

1.Install a clean version of Magento version 2.4-develop
2.Go to – Content>Configuration>Edit(Any configuration)>Header>Upload>Select .svg file
Actual result :
"We don't recognise or support this file extension type."

image

Expected result :
Upload image as SVG successfully .

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Feb 22, 2022
@pranav7870
Copy link

@magento I am working on this

@seak6adtn59v
Copy link

Any progress on this further?

@MagestyApps
Copy link

As you can see in the official docs, in default Magento you can upload only PNG, GIF or JPG images for logo. In order to upload an SVG you have to either add a customisation or use a 3rd part solution like this one: https://github.com/MagestyApps/module-web-images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Low Priority Backlog
  
Dev In Progress
Development

No branches or pull requests

7 participants