Wrong parameter are passed to setFreeShipping method

[baatractive]

Preconditions (*)

1. 2.4.3, master branch

Steps to reproduce (*)

1. The setFreeShipping requires an integer parameter while isFreeShipping method interface returns a boolean.

Expected result (*)

The following call to setFreeShipping passes a boolean value while it should pass an integer:

magento2/app/code/Magento/Quote/Model/Quote/Address/Total/Shipping.php

Line 76 in 81340cb

$address->setFreeShipping($isFreeShipping);

Actual result (*)

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @baatractive. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @baatractive,

Thanks for posting this issue!

We have checked the codebase in Magento 2.4-develop branch and we are able to reproduce the issue. This functionality may impact the shipping cost.

We have checked the below files in order to reproduce the issue:

1. Calling from collect function from the below line:
   

   magento2/app/code/Magento/Quote/Model/Quote/Address/Total/Shipping.php

   Line 76 in 81340cb

   $address->setFreeShipping($isFreeShipping);

2. $isFreeShipping variable is type of bool:
   

   magento2/app/code/Magento/Quote/Model/Quote/Address/FreeShippingInterface.php

   Line 19 in 81340cb

   public function isFreeShipping(\Magento\Quote\Model\Quote $quote, $items);

3. setFreeShipping method requires int type value:
   

   magento2/app/code/Magento/Quote/Model/Quote/Address.php

   Line 62 in 81340cb

   * @method Address setFreeShipping(int $value)

Hence confirming this issue.

Thanks

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-2583 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[engcom-Alfa]

Hi @reporter ,
Thanks for your reported bug, the internal team has fixed and delivered this issue successfully.
Please find related commits HERE.

Kindly upgrade to the latest Magento version 2.4-develop to retest the case.

In case of any Magento related issues found in 2.4-develop, you may report a new bug with all the information like Preconditions, detailed steps to reproduce, expected and actual Results along with screenshots/ screen recordings.

For any Magento related references, you may refer to the Magento user guide.

Thanks!