Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping costs not calculated correctly with table rates and virtual/physical products in cart #35185

Closed
OvalMedia opened this issue Mar 11, 2022 · 10 comments
Labels
Area: Shipping Component: Shipping Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.3-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@OvalMedia
Copy link

Preconditions (*)

  1. Magento 2.4.3-p1

Tables rates is configured to allow 0 shipping costs once the cart total reaches a threshold value. It fails when the cart contains both virtual and physical products even though the configuration "Include Virtual Products in Price Calculation" is set to "No".

Steps to reproduce (*)

  1. Table rates shipping table is set to zero shipping cost once you reach a total amount of 75,- € (63.0252 excl. tax)
    ship-config
  2. Table rates config is set to price vs. destination
  3. "Include Virtual Products in Price Calculation" set to "No"
  4. Create a simple (e.g. 34,- €) and a virtual product (e.g. 100,-€)
  5. Add both products to cart

Expected result (*)

Only the physical product's price should be taken into account when calculating the shipping price. The virtual product's price should be ignored completely.

checkout-expected

Actual result (*)

  1. The virtual product is taken into account
  2. Magento thinks the threshold is reached and sets the shipping cost to 0,-

checkout-actual

The exact same issue has been reported here: #27861
It is supposed to be fixed but it is not.

@m2-assistant
Copy link

m2-assistant bot commented Mar 11, 2022

Hi @OvalMedia. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@OvalMedia
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @OvalMedia. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@OvalMedia
Copy link
Author

Same thing in the latest dev version.

@engcom-November engcom-November self-assigned this Mar 14, 2022
@m2-assistant
Copy link

m2-assistant bot commented Mar 14, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link

Verified the issue on Magento 2.4-develop branch and the issue is reproducible:
Even after setting "Include Virtual Products in Price Calculation" to "No" in table rates configuration, shipping cost is getting applied on Virtual Product as well.
Cart without Virtual Product:
image
After adding Virtual Product:
image

@engcom-November engcom-November added Component: Shipping Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Shipping Reported on 2.4.3-p1 Indicates original Magento version for the Issue report. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 14, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Mar 14, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-2621 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Mar 14, 2022

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 15, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Mar 15, 2022
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Mar 30, 2022
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Mar 30, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Apr 4, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in High Priority Backlog Apr 21, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in High Priority Backlog Apr 21, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Apr 21, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Apr 21, 2022
@engcom-Alfa
Copy link
Contributor

Hi @reporter ,
Thanks for your reported bug, the internal team has fixed and delivered this issue successfully.
Please find related commits HERE.

Kindly upgrade to the latest Magento version 2.4-develop to retest the case.

In case of any Magento related issues found in 2.4-develop, you may report a new bug with all the information like Preconditions, detailed steps to reproduce, expected and actual Results along with screenshots/ screen recordings.

For any Magento related references, you may refer to the Magento user guide.

Thanks!

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Shipping Component: Shipping Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.3-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

No branches or pull requests

5 participants