Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tier_price to product comparison will crash the page #35244

Closed
1 of 5 tasks
Tjitse-E opened this issue Mar 29, 2022 · 6 comments
Closed
1 of 5 tasks

Adding tier_price to product comparison will crash the page #35244

Tjitse-E opened this issue Mar 29, 2022 · 6 comments
Labels
Area: Product Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.2-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@Tjitse-E
Copy link
Contributor

Preconditions (*)

  1. Magento 2.4.2-p1
  2. PHP 7.4

Steps to reproduce (*)

  1. Go to the Magento 2 admin panel
  2. Go to stores > attributes > product
  3. Search for 'tier_price'
  4. Open the tier price attribute and go to the 'Storefront properties' tab.
  5. Set 'Comparable on storefront' on 'yes'
  6. Go to the frontend
  7. Add two products to the products comparison
  8. View the product comparison

Expected result (*)

  1. See the product comparison, no errors

Actual result (*)

  1. The page will crash:

1 exception(s):
Exception #0 (Exception): Notice: Array to string conversion in vendor/magento/module-catalog/Block/Product/Compare> > /ListCompare.php on line 208


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Mar 29, 2022

Hi @Tjitse-E. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Mar 29, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link

Verified the issue on Magento 2.4-develop branch and the issue is reproducible.
Issue: Compare Products page is empty.
User have to click again on Compare Products link to display the products.
image

Exeption stacktrace:
[2022-03-29T10:19:03.325092+00:00] main.CRITICAL: Exception: Notice: Array to string conversion in /var/www/html/mg24/magento2/app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php on line 208 in /var/www/html/mg24/magento2/lib/internal/Magento/Framework/App/ErrorHandler.php:61 Stack trace: #0 /var/www/html/mg24/magento2/app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php(208): Magento\Framework\App\ErrorHandler->handler() #1 /var/www/html/mg24/magento2/app/code/Magento/Catalog/view/frontend/templates/product/compare/list.phtml(131): Magento\Catalog\Block\Product\Compare\ListCompare->getProductAttributeValue() #2 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/TemplateEngine/Php.php(71): include('/var/www/html/m...') #3 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Element/Template.php(263): Magento\Framework\View\TemplateEngine\Php->render() #4 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Element/Template.php(293): Magento\Framework\View\Element\Template->fetchView() #5 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Element/AbstractBlock.php(1095): Magento\Framework\View\Element\Template->_toHtml() #6 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Element/AbstractBlock.php(1099): Magento\Framework\View\Element\AbstractBlock->Magento\Framework\View\Element\{closure}() #7 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Element/AbstractBlock.php(660): Magento\Framework\View\Element\AbstractBlock->_loadCache() #8 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(578): Magento\Framework\View\Element\AbstractBlock->toHtml() #9 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(555): Magento\Framework\View\Layout->_renderBlock() #10 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(510): Magento\Framework\View\Layout->renderNonCachedElement() #11 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(606): Magento\Framework\View\Layout->renderElement() #12 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #13 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(510): Magento\Framework\View\Layout->renderNonCachedElement() #14 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(606): Magento\Framework\View\Layout->renderElement() #15 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #16 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(510): Magento\Framework\View\Layout->renderNonCachedElement() #17 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(606): Magento\Framework\View\Layout->renderElement() #18 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #19 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(510): Magento\Framework\View\Layout->renderNonCachedElement() #20 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(606): Magento\Framework\View\Layout->renderElement() #21 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #22 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(510): Magento\Framework\View\Layout->renderNonCachedElement() #23 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(606): Magento\Framework\View\Layout->renderElement() #24 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #25 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(510): Magento\Framework\View\Layout->renderNonCachedElement() #26 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(606): Magento\Framework\View\Layout->renderElement() #27 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #28 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(510): Magento\Framework\View\Layout->renderNonCachedElement() #29 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Layout.php(975): Magento\Framework\View\Layout->renderElement() #30 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/Interception/Interceptor.php(58): Magento\Framework\View\Layout->getOutput() #31 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/Interception/Interceptor.php(138): Magento\Framework\View\Layout\Interceptor->___callParent() #32 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/Interception/Interceptor.php(153): Magento\Framework\View\Layout\Interceptor->Magento\Framework\Interception\{closure}() #33 /var/www/html/mg24/magento2/generated/code/Magento/Framework/View/Layout/Interceptor.php(41): Magento\Framework\View\Layout\Interceptor->___callPlugins() #34 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Result/Page.php(260): Magento\Framework\View\Layout\Interceptor->getOutput() #35 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/View/Result/Layout.php(171): Magento\Framework\View\Result\Page->render() #36 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/Interception/Interceptor.php(58): Magento\Framework\View\Result\Layout->renderResult() #37 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/Interception/Interceptor.php(138): Magento\Framework\View\Result\Page\Interceptor->___callParent() #38 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/Interception/Interceptor.php(153): Magento\Framework\View\Result\Page\Interceptor->Magento\Framework\Interception\{closure}() #39 /var/www/html/mg24/magento2/generated/code/Magento/Framework/View/Result/Page/Interceptor.php(23): Magento\Framework\View\Result\Page\Interceptor->___callPlugins() #40 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/App/Http.php(120): Magento\Framework\View\Result\Page\Interceptor->renderResult() #41 /var/www/html/mg24/magento2/lib/internal/Magento/Framework/App/Bootstrap.php(264): Magento\Framework\App\Http->launch() #42 /var/www/html/mg24/magento2/pub/index.php(30): Magento\Framework\App\Bootstrap->run() #43 {main} [] []

@engcom-November engcom-November added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.2-p1 Indicates original Magento version for the Issue report. Component: Frontend Area: Product Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 29, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Mar 29, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-2719 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Mar 29, 2022

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 5, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Apr 5, 2022
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Apr 7, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Apr 11, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Apr 11, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog May 17, 2022
@engcom-Hotel
Copy link
Contributor

The issue has been fixed and merged. Please find the related commits on this link https://github.com/magento/magento2/search?q=AC-2719&type=commits. It will reflect in the 2.4.5 version.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Product Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.2-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

No branches or pull requests

4 participants