Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable max session size in admin - Unable to login to admin anymore #35312

Closed
5 tasks
engcom-November opened this issue Apr 14, 2022 · 19 comments · Fixed by #35489
Closed
5 tasks

Disable max session size in admin - Unable to login to admin anymore #35312

engcom-November opened this issue Apr 14, 2022 · 19 comments · Fixed by #35489
Assignees
Labels
Area: Account Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.

Comments

@engcom-November
Copy link

Preconditions (*)

  1. Magento 2.4-develop, 2,4,4

Steps to reproduce (*)

  1. Store > Settings > Configuration. - Advanced and choose System - Security - set Max Session Size in Admin to 0 and save
  2. Login to admin

Expected result (*)

  1. [Screenshots, logs or description]
  2. Login works

Actual result (*)

  1. [Screenshots, logs or description]
  2. Unable to login

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Apr 14, 2022

Hi @engcom-November. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Apr 14, 2022
@engcom-November engcom-November added the Reported on 2.4.4 Indicates original Magento version for the Issue report. label Apr 14, 2022
@mgwalk
Copy link

mgwalk commented Apr 15, 2022

I am getting the same issue.
I see admin login
Enter user and pass.
Page looks like it just refreshes

@engcom-Delta
Copy link
Contributor

Hi @engcom-November ,
We have verified this issue on Magento 2.4 develop and 2.4.4 instances. Found that issue is reproducible on both instances.
Hence issue is confirmed.
Please find the attaches screenshots for reference.

  1. Login to admin
  2. Store > Settings > Configuration. - Advanced and choose System - Security - set Max Session Size in Admin to 0 and save

Screenshot 2022-04-19 at 5 21 41 PM

3. observe that user logged out 4. Login to admin again

Screenshot 2022-04-19 at 5 34 35 PM

@engcom-Delta engcom-Delta added Area: Account Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Apr 19, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Apr 19, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-2883 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Apr 19, 2022

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-November engcom-November added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 21, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Apr 21, 2022
@mgwalk
Copy link

mgwalk commented Apr 23, 2022

I was able to fix by updating frontend and admin before upgrading to 2.4.4.
I also had magefan blog which needed updated.

@taintedstephen
Copy link

taintedstephen commented Apr 27, 2022

I had the same issue because I set the session size to 0 before this release to fix a different issue. You can update the value back to default via the cli to resolve this issue:

bin/magento config:set system/security/max_session_size_admin 256000

@nisha-vaghela
Copy link
Contributor

@magento I am working on this

@hostep
Copy link
Contributor

hostep commented May 4, 2022

Possible solution from #35414, credits to @advocat:

Root Cause
magento2/lib/internal/Magento/Framework/Session/SaveHandler.php

Line 129

if ($sessionSize !== null && $sessionMaxSize < $sessionSize) {

Should be:

if ($sessionMaxSize !== null && $sessionMaxSize < $sessionSize) {

@VincentMarmiesse
Copy link
Contributor

I had the same issue because I set the session size to 0 before this release to fix a different issue. You can update the value back to default via the cli to resolve this issue:

bin/magento config:set system/security/max_session_size_admin 256000

On my store, 256000 was not enough, and I have setted 512000.

Be careful, there is also a frontend limit: system/security/max_session_size_storefront.

@nisha-vaghela
Copy link
Contributor

@magento give me test instance

@magento-deployment-service
Copy link

Hi @nisha-vaghela. Thank you for your request. Comments like @magento give me test instance are intended for instance deployments on Pull Requests. Please use comment like: @magento give me 2.4-develop instance to request an instance on an issue.

@nisha-vaghela
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @nisha-vaghela. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@m2-community-project m2-community-project bot added Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels May 19, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in High Priority Backlog May 20, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in High Priority Backlog May 20, 2022
@glo71317
Copy link
Contributor

Based on the priority internal team is working on the automation test and will deliver soon for 2.4.5 release

@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog May 23, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog May 23, 2022
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog May 23, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog May 30, 2022
@engcom-Alfa
Copy link
Contributor

Hello @engcom-November
As I can see this issue got fixed in the scope of the internal Jira ticket AC-2883 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-2883&type=commits

Based on Jira, target version is 2.4.5

@kevinjavitz
Copy link

Just as another note if the customer side session is at 0 or the system/security/max_session_size_storefront path you will get an error like this when adding to cart: There is an error. Please Contact store administrator coming from vendor/magento/framework/Session/SaveHandler.php:133 so it is really not obvious when debugging where this error is coming from, I'm adding this note hoping that when people google this issue this page will come up, again the fix it doing:

bin/magento config:set system/security/max_session_size_storefront 256000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Account Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Development

Successfully merging a pull request may close this issue.