Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order remains in status 'processing' after shipping, if items get partially refunded #35528

Closed
1 of 5 tasks
vseager opened this issue May 24, 2022 · 13 comments
Closed
1 of 5 tasks
Assignees
Labels
Area: Order Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@vseager
Copy link
Contributor

vseager commented May 24, 2022

Preconditions and environment

This is a repeat of issue #31063 which is closed despite the issue still being present in 2.4.3-p2.

  • Magento 2.4.3-p2

Steps to reproduce

  1. Create an order with multiple items ordered.
  2. From the admin, create an invoice for the order.
  3. From the admin, create a credit memo and refund an item only partially.
  4. From the admin, create a shipping for the order and the remaining items.
  5. Observe the order status.

Expected result

Status of the order should be 'Complete'. (As it is, when one item is fully refunded)

Actual result

Status of the order stays 'Processing'.

Additional information

  1. Create an order for a Product in the quantity of 10
  2. From Admin, create an Invoice for the order. (for all 10 items)
  3. Create a Credit Memo for a quantity of 5 items
  4. Ship the remaining 5 items

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented May 24, 2022

Hi @vseager. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented May 25, 2022

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

Hi @vseager ,
Thank you for raising an issue , We tried to reproduce the issue on Magento 2.4 Develop instance, it is not reproducible.
Order status is 'complete' after shipping successfully.

followed below steps:

  1. Create an order with multiple items ordered.

Screenshot 2022-05-25 at 7 04 04 PM

  1. From the admin, create an invoice for the order.

Screenshot 2022-05-25 at 7 08 59 PM

  1. From the admin, create a credit memo and refund an item only partially.

Screenshot 2022-05-25 at 7 11 53 PM

  1. From the admin, create a shipping for the order and the remaining items.
    Before:

Screenshot 2022-05-25 at 7 13 01 PM

After:
Screenshot 2022-05-25 at 7 14 14 PM

Screenshot 2022-05-25 at 7 30 38 PM

Observe the order status. it is 'complete' status only

@engcom-Delta engcom-Delta added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: needs update Additional information is require, waiting for response and removed Issue: ready for confirmation labels May 25, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board May 25, 2022
@m2-community-project m2-community-project bot removed the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label May 25, 2022
@vseager
Copy link
Contributor Author

vseager commented May 25, 2022

@engcom-Delta Thanks for your update, however, I don't believe you have followed the steps to reproduce correctly.

You are adding two different items to the cart and refunding the total quantity of one of those items. This issue happens only when you partially refund a single SKU where the quantity is greater than 1 for that SKU.

Instead of refunding all 5 of 25-MB05, you need to refund 2 of them (or any number less than 5), then try to ship the remaining items.

Please try again to reproduce this issue, but this time add only one product SKU to the cart, following these steps:

  1. Go to SKU 24-MB05
  2. Add more than one 24-MB05 to the cart (for example 5) - Your cart should show only ONE product but a QTY of 5
  3. Invoice the whole order (5 x 25-MB05)
  4. Create a credit memo for only 2 x 25-MB05
  5. Create a shipment for the remaining 3 x 25-MB05

@engcom-Delta engcom-Delta added Area: Order Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Issue: needs update Additional information is require, waiting for response labels May 26, 2022
@m2-community-project m2-community-project bot moved this from Needs Update to Ready for Confirmation in Issue Confirmation and Triage Board May 26, 2022
@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels May 26, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board May 26, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-3178 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented May 26, 2022

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Delta
Copy link
Contributor

Hi @vseager ,

Thank you so much for sharing the detailed steps , We tried once again to reproduce it , Yes issue is reproducible with a product that has 5 quantity .

Hence marked issue as 'Issue Confirmed'.

  1. Go to SKU 24-MB05
  2. Add more than one 24-MB05 to the cart (for example 5) - Your cart should show only ONE product but a QTY of 5

Screenshot 2022-05-26 at 12 54 49 PM

  1. Invoice the whole order (5 x 25-MB05)

Screenshot 2022-05-26 at 12 56 11 PM

  1. Create a credit memo for only 2 x 25-MB05

Screenshot 2022-05-26 at 12 58 50 PM

  1. Create a shipment for the remaining 3 x 25-MB05

Screenshot 2022-05-26 at 1 21 51 PM

Screenshot 2022-05-26 at 1 22 16 PM

Thanks

@sidolov sidolov added the Priority: P3 May be fixed according to the position in the backlog. label May 26, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in Low Priority Backlog May 26, 2022
@nisha-vaghela
Copy link
Contributor

@magento i am working on this.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in Low Priority Backlog Jun 13, 2022
@stupachenko
Copy link

@nisha-vaghela It was broken in cbc352e

@hostep
Copy link
Contributor

hostep commented Oct 3, 2022

Closed without any comments? Possibly fixed by AC-3178::Order remains in status 'processing' after shipping, if items is get partially refunded

@engcom-Hotel
Copy link
Contributor

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-3178 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-3178&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks

@kwilliams-concentrix
Copy link

Can we get a patch for our version? 2.4.5p-2

@qlhu
Copy link

qlhu commented Jan 15, 2024

Just FYI the code fix doesn't work to partial refund/shipment to grouped product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Order Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

No branches or pull requests

10 participants