Hi @ndlinh-celtic. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento run all tests

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ndlinh-celtic can you provide information on how to trigger the incorrect behavior?

@bgorski

Magento default doesn't have credit card payment form, so it's difficult to re-produce this problem with default magento instance.

I'm developing a payment gateway that have credit card form. In this form, I use a rule validate-card-number provided by
Magento_Payment/js/model/credit-card-validation/validator.js to validate credit card number. This rule use a function (alias: creditCardNumberValidator) in Magento_Payment/js/model/credit-card-validation/credit-card-number-validator.js and credit card type information declare in Magento_Payment/js/model/credit-card-validation/credit-card-number-validator/credit-card-type.js. The credit card type information has format like this:

var types = [
    {
        title: 'Visa',
        type: 'VI',
        pattern: '^4\\d*$',
        gaps: [4, 8, 12],
        lengths: [16],
        code: {
            name: 'CVV',
            size: 3
        }
    },
    {
        title: 'MasterCard',
        type: 'MC',
        pattern: '^(?:5[1-5][0-9]{2}|222[1-9]|22[3-9][0-9]|2[3-6][0-9]{2}|27[01][0-9]|2720)[0-9]{12}$',
        gaps: [4, 8, 12],
        lengths: [16],
        code: {
            name: 'CVC',
            size: 3
        }
    },
    ...
]

The statement cardInfo = creditCardNumberValidator(number).card; in validate-card-number validate function return credit card type information store in cardInfo then use cardInfo.title to compare with allowedTypes[i].type. allowedTypes is an array contains information as screenshot bellow:

So, use title to compare with type is incorrect. The validation never pass.
After apply the changes in this PR, all validation rules on my credit card form working without any problem.

@magento give me test instance

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you.

@magento give me 2.4-develop instance

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Alfa, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Hi @engcom-Alfa, here is your Magento Instance: https://d84db8181a6db432bee2c756fd058d1c.instances.magento-community.engineering
Admin access: https://d84db8181a6db432bee2c756fd058d1c.instances.magento-community.engineering/admin_d579
Login: 0b6391ae
Password: db37cc64d354

@magento give me 2.4-develop instance

Hi @ndlinh-celtic. Thank you for your request. I'm working on Magento instance for you.

Hi @ndlinh-celtic, here is your Magento Instance: https://4bc47752962349a56d0a0291c7603aba.instances.magento-community.engineering
Admin access: https://4bc47752962349a56d0a0291c7603aba.instances.magento-community.engineering/admin_c5ea
Login: bbbcf47c
Password: cda1a4be59ef

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Hi @ndlinh-celtic

Thanks for your contribution and collaboration.

I have gone to through yours comment "Magento default doesn't have credit card payment form, so it's difficult to re-produce this problem with default magento instance."
I have enabled PayPal in my local 2.4-develop, in frontend I got credit card payment form.
Kindly assist me, How can I can reproduce this issue?
Below is the screenshot for your reference:

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Hi @ndlinh-celtic
With the default Paypal payment methods credit card form, we are not able to see any JS errors as such in the console.

1. If it is specific by adding a new payment gateway with a new CC form including card validation, Ca you please confirm?
2. Can you please let us know step-by-step procedure you have followed to come up with a new payment gateway for better understanding?
3. Also, even after multiple tries, there are 3 auto-test jobs are getting failed, Can you help us with your fixes on this?

Thanks in advance!

Hi @ndlinh-celtic
I tried to reach you thru Slack channel, but could not find you there!
You are invited to join the Magento Community Slack Channel, please feel free to join the workspace.

@magento give me 2.4-develop instance

Hi @ndlinh-celtic. Thank you for your request. I'm working on Magento instance for you.

Hi @ndlinh-celtic, here is your Magento Instance: https://4bc47752962349a56d0a0291c7603aba.instances.magento-community.engineering
Admin access: https://4bc47752962349a56d0a0291c7603aba.instances.magento-community.engineering/admin_9f9e
Login: ecfa3d5d
Password: 97f4f396724f