Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Add missing semicolons for 'const' and 'let' #35711

Closed
5 tasks done
m2-assistant bot opened this issue Jul 1, 2022 · 4 comments · Fixed by #35540
Closed
5 tasks done

[Issue] Add missing semicolons for 'const' and 'let' #35711

m2-assistant bot opened this issue Jul 1, 2022 · 4 comments · Fixed by #35540
Assignees
@fredden
Labels
Area: Admin UI Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jul 1, 2022

This issue is automatically created based on existing pull request: #35540: Add missing semicolons for 'const' and 'let'

Description

Semicolons are required according to the Magento coding standard:
https://github.com/magento/magento-coding-standard/blob/50e7c2ad3d7110b06527d75a1aa954b7c20f6ea1/eslint/.eslintrc-magento#L89

While there are many missing semicolons in these files, I have only fixed the const and let statements as these are causing problems for users in the admin - see #35325

Ideally these files would conform to the Magento coding standard. Applying the auto-fix feature of eslint produced a much larger set of changes.

Related Pull Requests

Fixed Issues

  1. Fixes Magento 2.4.4 admin panel - Uncaught SyntaxError: Unexpected token 'const' #35325

Manual testing scenarios

See #35325

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jul 1, 2022
@m2-assistant m2-assistant bot mentioned this issue Jul 1, 2022
Merged
6 tasks
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Jul 1, 2022
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Jul 1, 2022
@engcom-Alfa engcom-Alfa added Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jul 1, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Jul 1, 2022
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Jul 1, 2022
@engcom-Alfa engcom-Alfa added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jul 1, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-3773 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Jul 1, 2022

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Alfa engcom-Alfa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jul 1, 2022
@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-3773

1 similar comment
@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-3773

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredden fredden

Labels
Area: Admin UI Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing semicolons for 'const' and 'let' fredden/magento2
3 participants
@fredden @engcom-Alfa @github-jira-sync-bot