Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Improve price index consistency and run time #35719

Closed
m2-assistant bot opened this issue Jul 4, 2022 · 2 comments · Fixed by #35524
Closed

[Issue] Improve price index consistency and run time #35719

m2-assistant bot opened this issue Jul 4, 2022 · 2 comments · Fixed by #35524
Labels
Area: Performance Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jul 4, 2022

This issue is automatically created based on existing pull request: #35524: Improve price index consistency and run time


Description (*)

With a very large product set (~213k) on 1 of our sites, the price index (and through the use of MSI, the inventory index) takes a very long time to complete, with multiple hours spent executing deleteIndexData. It seems the primary cause of this slowdown is string to int conversions or vice versa in MySQL, and ensuring that all IDs are integers beforehand yields much more consistent and reasonable performance on these larger sets

Manual testing scenarios (*)

  1. Get a bunch of products
  2. Use MSI
  3. Have multiple stock sources (with a non default providing most of the stock)
  4. Run an inventory index (the issue is most noticeable here due to InventoryCatalog's plugin "PriceIndexUpdatePlugin", and its call to reindexList with a very large number of IDs)

Contribution checklist (*)

  • [✓] Pull request has a meaningful description of its purpose
  • [✓] All commits are accompanied by meaningful commit messages
  • [✓] All new or changed code is covered with unit/integration tests (if applicable)
  • [✓] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [✓] All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jul 4, 2022
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Jul 4, 2022
@engcom-Alfa engcom-Alfa added Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Performance Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jul 4, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-5887 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Jul 4, 2022

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Performance Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

2 participants