Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message when dismiss all completed tasks #36048

Closed
5 tasks
dzdaniel opened this issue Aug 29, 2022 · 23 comments
Closed
5 tasks

Error message when dismiss all completed tasks #36048

dzdaniel opened this issue Aug 29, 2022 · 23 comments
Assignees
Labels
Area: Admin UI Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@dzdaniel
Copy link

Preconditions and environment

  • Magento version 2.4.4

Steps to reproduce

  1. Update products in bulk from product grid
  2. Go to bulk action logs and wait until all action success
  3. Click to View Details in system message

Expected result

The system message should show without error.

Actual result

It's showing error message
image
And the log in system.log is
[2022-08-29T10:03:41.237871+00:00] .CRITICAL: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '0f2687a6-7b98-4f4d-9847-8cf7afdcf7c1' for key 'magento_acknowledged_bulk.MAGENTO_ACKNOWLEDGED_BULK_BULK_UUID', query was: INSERT INTO magento_acknowledged_bulk (bulk_uuid) VALUES (?) [] []

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Aug 29, 2022

Hi @dzdaniel. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Aug 29, 2022

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@UglyWillDuckling
Copy link

I can confirm being able to reproduce this issue on one of our projects as well. I will update with more info.

@UglyWillDuckling
Copy link

From what I can tell the issue is happening because of jQuery and the way it is deciding if an error occurred.
Basically, the response from Magento is empty and jquery expects json. This throws a parsing error.

It should be quite easy to fix by just adding an empty json result but I still need to try this.

@engcom-Hotel
Copy link
Contributor

Duplicate of #35971

@engcom-Hotel engcom-Hotel marked this as a duplicate of #35971 Aug 30, 2022
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Aug 30, 2022
@engcom-Hotel
Copy link
Contributor

Reopening this issue. The issue was mistakenly closed.

@engcom-Delta
Copy link
Contributor

✔️ Issue confirmed

Issue got reproduced in 2.4-develop branch.

Description:

While updating the product in bulk , In bulk action logs it showing system message with the error.

Pre-requisite:

2.4-develop

Steps to reproduce:

  1. Update products in bulk from product grid

  2. Opened bulk action logs and clicked on View Details in system message

  3. checked in system.log file

Expected result:

Only system message is display without the error.

Actual result:

System message displayed along with an error

Screenshots:

  1. Update products in bulk from product grid

Screenshot 2022-09-09 at 2 31 46 PM

Screenshot 2022-09-09 at 2 32 22 PM

  1. Opened bulk action logs and clicked on View Details in system message

Screenshot 2022-09-09 at 2 33 09 PM

Screenshot 2022-09-09 at 2 33 32 PM

we can see the system message with an error .

  1. checked in system.log file

Screenshot 2022-09-09 at 2 41 07 PM

[2022-09-09T09:03:21.463071+00:00] main.CRITICAL: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '673933f0-4bce-40c0-a75b-dc02b9cf11db' for key 'magento_acknowledged_bulk.MAGENTO_ACKNOWLEDGED_BULK_BULK_UUID', query was: INSERT INTO magento_acknowledged_bulk (bulk_uuid) VALUES (?) [] []

Hence, confirming the issue.

Thanks.

@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Ui Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Admin UI Reported on 2.4.4 Indicates original Magento version for the Issue report. labels Sep 9, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Sep 9, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6658 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Sep 9, 2022

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 13, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Sep 13, 2022
@sdaugherty-rp
Copy link

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Sep 29, 2022

Hi @sdaugherty-rp! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@sdaugherty-rp
Copy link

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Sep 29, 2022

Hi @sdaugherty-rp! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@sdaugherty-rp
Copy link

@magento I am working on this

@sdaugherty-rp
Copy link

From what I can tell the issue is happening because of jQuery and the way it is deciding if an error occurred. Basically, the response from Magento is empty and jquery expects json. This throws a parsing error.

It should be quite easy to fix by just adding an empty json result but I still need to try this.

Spot on. Added this PR/Commit: f7570c2

Reused similar approach in vendor/magento/module-asynchronous-operations/Controller/Adminhtml/Bulk/Retry.php to add non-empty json response:

image

@floorz floorz removed their assignment Sep 29, 2022
@FadedOut
Copy link

FadedOut commented Jan 3, 2023

From what I can tell the issue is happening because of jQuery and the way it is deciding if an error occurred. Basically, the response from Magento is empty and jquery expects json. This throws a parsing error.
It should be quite easy to fix by just adding an empty json result but I still need to try this.

Spot on. Added this PR/Commit: f7570c2

Reused similar approach in vendor/magento/module-asynchronous-operations/Controller/Adminhtml/Bulk/Retry.php to add non-empty json response:

image

Just wish to report that this commit seemed to solve the issue for me. 👍🙂 Many thanks! It was annoying clicking the OK button after every X esp if there are many X to click (dismiss).

@mfickers
Copy link
Contributor

I can confirm that this commit fixes the issue.

@sdaugherty-rp could you please create a PR for this, so that this fix can be merged into the main code base?

@hostep
Copy link
Contributor

hostep commented Jun 3, 2023

@mfickers: I have the feeling that this might have been fixed in Magento 2.4.6 by ACP2E-1245: "Something went wrong" error is displayed when clearing the completed bulk tasks. (the commit are a mess, but I think this might be the merge commit: fb586ea)

Maybe you can test this as well and let us know if this fixed it as well in your case, so we can then close this issue?

@FadedOut
Copy link

FadedOut commented Jun 5, 2023

This was indeed properly fixed in 2.4.6 without any manual file changes. Which merge fixed it that I'm not sure of though.

@yurii-zhuravlov
Copy link

@mfickers: I have the feeling that this might have been fixed in Magento 2.4.6 by ACP2E-1245: "Something went wrong" error is displayed when clearing the completed bulk tasks. (the commit are a mess, but I think this might be the merge commit: fb586ea)

Maybe you can test this as well and let us know if this fixed it as well in your case, so we can then close this issue?

I can confirm that this commit fixes the issue. I've created composer patch based on this commit changes and it works great for Magento 2.4.5-p1

@hostep
Copy link
Contributor

hostep commented Jul 9, 2023

Thanks for the confirmations guys, I think we should close this ticket now? @dzdaniel or @engcom-Delta or @engcom-Hotel, can one of you take care of closing the ticket? Thanks!

@engcom-Bravo
Copy link
Contributor

Thanks for your contribution & collaboration over here @hostep.

As I can see this issue got fixed in the scope of the internal Jira ticket AC-7698 by the internal team
Related commits: https://github.com/search?q=repo%3Amagento%2Fmagento2+ACP2E-1245&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Jul 10, 2023
@hostep
Copy link
Contributor

hostep commented Jul 10, 2023

Thanks @engcom-Bravo, can you also close #36221 then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects