Catalog Price Rule single product reindex works incorrectly

[Myroslava-Myroslava]

Preconditions and environment

• Magento 2.4.3 , 2.4-develop

• Magento multi store setup. 2 Websites (W1 and W2)

• Create the the Product's Attribute (e.g. "Age Group") with the scope "website" and "Use for Promo Rule Conditions" set to "yes".

• The Product assigned to both websites and having Attribute with option 1 for W1, and option 2 for W2 (e.g. "adults" for W1 and "children" for W2).

Steps to reproduce

1. Create a Catalog Price Rule.
2. In the rule as a condition, age groups is "adults"
3. Assign the rule to both websites (W1 and W2).
4. Reindex and clear cache
5. Admin - Open the Product edit page.
6. Select scope W1 on the Product edit page.
7. Save the product.
8. Open Front end - W1 catalog as a User - see the price of the Product.
9. Admin - Open the Product edit page again.
10. Select scope W2 on the Product edit page and save with no changes made
11. Open Front end - W2 catalog as a User - see the price of the Product.

Expected result

The rule is applied (the price is reindexed) to the product only for the websites for which the attribute has an option value matching the rule.

In our case:
The rule is applied (the discount is applied) to the Product on W1 and NOT applied on W2.

Actual result

The rule is applied to the product NOT taking into account the SCOPE chosen.
The rule takes the value of the attributes from the Product's edit page on which save event happens. And then the rule is applied or not applied (according to these values) to ALL websites.

In our case:

1. After the save for W1: the rule is applied (the discount is applied) to the Product on BOTH W1 and on W2.
2. After the save for W2: the rule is NOT applied (the discount is applied) on BOTH websites.

Additional information

The process is triggered in the \Magento\CatalogRule\Model\Indexer\IndexBuilder::reindexById. Inside, \Magento\CatalogRule\Model\Indexer\IndexBuilder::assignProductToRule applies the rule to all the websited, which is wrong

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Myroslava-Myroslava. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Myroslava-Myroslava]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @Myroslava-Myroslava. Thank you for your request. I'm working on Magento instance for you.

[Myroslava-Myroslava]

@magento I am working on this

[m2-assistant]

Hi @Myroslava-Myroslava! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

[magento-deployment-service]

Hi @Myroslava-Myroslava, here is your Magento Instance: https://fa8b3b63aea52a68f7ed73f34d55e11f.instances.magento-community.engineering
Admin access: https://fa8b3b63aea52a68f7ed73f34d55e11f.instances.magento-community.engineering/admin_14ce
Login: bbecadb0
Password: 6bc4fd8ce045

[Myroslava-Myroslava]

@magento add to contributors team

[m2-assistant]

Hi @Myroslava-Myroslava! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

[Myroslava-Myroslava]

@magento I am working on this

[Myroslava-Myroslava]

We created 2 websites:

The rule:

We select the option matching the rule for the Main Website and save:

Visit catalog page on a Main Website as a user - the rule is applied (which is correct):

Select the option NOT matching the rule for the Website 2 and save:

Visit catalog page on a Main Website as a user - the rule is NOT applied (which is wrong since the value for Main Website still matches the rule):

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Verified the issue on Magento 2.4-develop instance and the issue is reproducible. Hence updating the description with exact steps and confirming the issue.

After saving the product with no changes made - catalog price rule got removed on front end.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6810 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[glo35082]

Our internal team has started working on this.

[engcom-Hotel]

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-6810 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-6810&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks