-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minify Html issue #36183
Comments
Hi @Nuranto. Thank you for your report.
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
For more details, review the Magento Contributor Assistant documentation. Add a comment to assign the issue: To learn more about issue processing workflow, refer to the Code Contributions.
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
#32153 |
Yes sorry, I did search, however didn't find it. |
Preconditions and environment
Steps to reproduce
Edit a template having a
if
conditionreplace one
<?php endif ?>
with<?php //test comment ?><?php endif ?>
Expected result
html file gets minified correctly
Actual result
The
endif
is removed in minified html. The page gives a 500 result.Additional information
Even if it is a bad coding style, it should not fail minify.
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: