Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify Html issue #36183

Closed
1 of 5 tasks
Nuranto opened this issue Sep 23, 2022 · 3 comments
Closed
1 of 5 tasks

Minify Html issue #36183

Nuranto opened this issue Sep 23, 2022 · 3 comments

Comments

@Nuranto
Copy link
Contributor

Nuranto commented Sep 23, 2022

Preconditions and environment

  • Magento version 2.4.5

Steps to reproduce

Edit a template having a if condition

replace one <?php endif ?> with <?php //test comment ?><?php endif ?>

Expected result

html file gets minified correctly

Actual result

The endif is removed in minified html. The page gives a 500 result.

Additional information

Even if it is a bad coding style, it should not fail minify.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2022

Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn
Copy link
Contributor

mrtuvn commented Sep 23, 2022

#32153
Looks like same case. Can you read it to make sure it's same with your ?

@Nuranto
Copy link
Contributor Author

Nuranto commented Sep 23, 2022

Yes sorry, I did search, however didn't find it.

@Nuranto Nuranto closed this as completed Sep 23, 2022
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants