Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale links to topics migrated to Adobe domains #36230

Closed
1 of 5 tasks
Tomasito665 opened this issue Oct 3, 2022 · 8 comments · May be fixed by #36238
Closed
1 of 5 tasks

Stale links to topics migrated to Adobe domains #36230

Tomasito665 opened this issue Oct 3, 2022 · 8 comments · May be fixed by #36238
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@Tomasito665
Copy link
Contributor

Summary (*)

Adobe migrated Magento documentation to Adobe domains.
https://devdocs.magento.com/migrated.html

Examples (*)

The pull request description template itself is a clear example:

Please provide [Severity](https://devdocs.magento.com/guides/v2.4/contributor-guide/contributing.html#backlog) assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

The link points to https://devdocs.magento.com/guides/v2.4/contributor-guide/contributing.html#backlog, which was moved to https://developer.adobe.com/commerce/contributor/guides/code-contributions/#community-backlog-priority.

Proposed solution

The solution is simple enough: update the links :-)


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@Tomasito665 Tomasito665 added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Oct 3, 2022
@m2-assistant
Copy link

m2-assistant bot commented Oct 3, 2022

Hi @Tomasito665. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sdzhepa
Copy link
Contributor

sdzhepa commented Oct 3, 2022

Hello @Tomasito665

Could you please be more specific or provide more details about where exact wrong links?
In the description, you provided an example for the pull request but PR template does not have a section for Severity

Template in use: https://github.com/magento/magento2/blob/2.4-develop/.github/PULL_REQUEST_TEMPLATE.md

For issues, all templates can be found https://github.com/magento/magento2/tree/2.4-develop/.github/ISSUE_TEMPLATE

  1. bug_report.yaml - has correct(updated) link for severity bug_report.yaml#L65
  2. developer-experience-issue.md has wrong link developer-experience-issue.md#L23 BUT it is fixed in this PR Convert GitHub issue templates to issue forms #35990
  3. feature_request.md - does not have this section for Severity
  4. story.md - does not have this section for Severity

Noteі:

  • old links could be only in the old issues(that were created/reported before changes). I think(imho) the effort and time required to update all old issues does not worth the result
  • all newly reported issues should have correct links

@Tomasito665
Copy link
Contributor Author

Hello @sdzhepa,

Thanks for coming back to me. If you click New issueDeveloper experience issue, the template still contains the old links. Many links on other documentation are also old, including some links on the main README. A few examples:

For more examples, search for https://docs.magento.com in this repository:
https://github.com/magento/magento2/search?q=https%3A%2F%2Fdocs.magento.com

old links could be only in the old issues(that were created/reported before changes). I think(imho) the effort and time required to update all old issues does not worth the result

I agree.

@engcom-November engcom-November self-assigned this Oct 4, 2022
@m2-assistant
Copy link

m2-assistant bot commented Oct 4, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Hi @Tomasito665 ,
Thank you for reporting and collaboration. I believe updates/modifications to devdocs should be reported in this repository. Hence raised new issue report for the same: magento/devdocs#9523 . Kindly check and move on this issue for latest updates / solutions on the same.
Thank you.

@engcom-November engcom-November added Issue: needs update Additional information is require, waiting for response and removed Progress: needs update labels Oct 4, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Oct 4, 2022
@m2-community-project m2-community-project bot moved this from Needs Update to Ready for Confirmation in Issue Confirmation and Triage Board Oct 4, 2022
@m2-community-project m2-community-project bot added Issue: ready for confirmation Issue: needs update Additional information is require, waiting for response and removed Issue: needs update Additional information is require, waiting for response Issue: ready for confirmation labels Oct 4, 2022
@engcom-November engcom-November added Issue: needs update Additional information is require, waiting for response and removed Issue: needs update Additional information is require, waiting for response labels Oct 4, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Oct 4, 2022
@Tomasito665
Copy link
Contributor Author

Hi @engcom-November,

I filed a pull request to update all links to migrated documentation to their updated URLs. It has been two days since I filed the PR and yet CI checks appear in progress still. How long do they normally take? Am I missing something?

Thanks

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 6, 2022
@engcom-November
Copy link
Contributor

engcom-November commented Oct 14, 2022

Hi @Tomasito665 ,
Thank you for the response. The issue raised by me in devdocs repository has been closed.
Reason: They are currently working on updating the navigation on the devdocs home page to point to new locations and will not implement redirects on devdocs until they finish migrating all content. Kindly check this https://community.magento.com/t5/News-Announcements/Community-Monthly-Update-February-2022/td-p/492851#toc-hId-828475519 for more information.
Thank you.

@Tomasito665
Copy link
Contributor Author

Tomasito665 commented Oct 17, 2022

Hi @engcom-November,

Thanks for your response. The issue you describe is about building in redirects from the old to the new URLs in the Magento docs repo, which is related but different than the issue described in this issue. In this issue, I refer to the URLs in this repository, magento2, which point to the old URLs. The pull request I opened updates all links to their new locations, removing the need to redirect at all. Because of that, I would like to reopen the issue until the pull request is closed. Could you do that?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
3 participants