Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphQl] products query price filter issues with net prices entered in adminhtml #36337

Open
1 of 5 tasks
t-heuser opened this issue Oct 20, 2022 · 11 comments
Open
1 of 5 tasks
Labels
Area: Catalog Component: TaxGraphQl Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for grooming Reported on 2.4.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@t-heuser
Copy link

t-heuser commented Oct 20, 2022

Preconditions and environment

  • Magento version: 2.4.5
  • tax/calculation/price_includes_tax must be set to Excluding Tax so that prices in entered in adminhtml are without tax
  • tax/display/type must be set to Including Tax so that prices are shown including tax in GraphQl
  • A product with a price of 10
  • A tax rule which is applied for the store you use when testing

Steps to reproduce

  1. Execute the following query: (replace category_uid with your category or remove it)
query route {
  products(sort: { price: ASC }, filter: { price: { from: 10, to: 15}, category_uid: { eq: "Mzk=" }}) {
    items {
      price_range {
        minimum_price {
          final_price {
            value
          }
        }
      }
    }
  }
}

Expected result

All products with a price including tax above 10 or more and 15 or less are included in the response.

Actual result

Products with a price including tax above 10 or more are only included if the price that is set in adminhtml is above 10, the tax is not taken into account when filtering.
The same goes for the "to" part of the filter. Products with a price greater than 15 including tax are included in the result.

Here you can see the results of the query when filtering for a price from 10 to 15:

{
  "data": {
    "products": {
      "items": [
        {
          "price_range": {
            "minimum_price": {
              "final_price": {
                "value": 13.52
              }
            }
          }
        },
        {
          "price_range": {
            "minimum_price": {
              "final_price": {
                "value": 14.88
              }
            }
          }
        },
        {
          "price_range": {
            "minimum_price": {
              "final_price": {
                "value": 15.898401
              }
            }
          }
        }
      ]
    }
  }
}

A product with a price of 15.89 is included because the price without tax is 13.35 (german tax rate of 19% is applied).
A product with a price of 10.79 is not included because the price without tax is 9.06 (also german tax rate).
The product is only included when setting the price filter range from 9 to 15, here is the result:

{
  "data": {
    "products": {
      "items": [
        {
          "price_range": {
            "minimum_price": {
              "final_price": {
                "value": 10.793301
              }
            }
          }
        },
        {
          "price_range": {
            "minimum_price": {
              "final_price": {
                "value": 11.65
              }
            }
          }
        },
        {
          "price_range": {
            "minimum_price": {
              "final_price": {
                "value": 11.65
              }
            }
          }
        },
        {
          "price_range": {
            "minimum_price": {
              "final_price": {
                "value": 13.52
              }
            }
          }
        },
        {
          "price_range": {
            "minimum_price": {
              "final_price": {
                "value": 14.88
              }
            }
          }
        },
        {
          "price_range": {
            "minimum_price": {
              "final_price": {
                "value": 15.898401
              }
            }
          }
        }
      ]
    }
  }
}

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Oct 20, 2022

Hi @oneserv-heuser. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@t-heuser
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @oneserv-heuser. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @oneserv-heuser, here is your Magento Instance: https://7f358f5f7a31071afb25cf6cec577380.instances.magento-community.engineering
Admin access: https://7f358f5f7a31071afb25cf6cec577380.instances.magento-community.engineering/admin_5086
Login: 5d7193d2
Password: fc844dae7ce2

@t-heuser
Copy link
Author

I can reproduce the issue on a vanilla magento instance with version 2.4-develop

@engcom-Bravo engcom-Bravo self-assigned this Oct 20, 2022
@m2-assistant
Copy link

m2-assistant bot commented Oct 20, 2022

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.5 Indicates original Magento version for the Issue report. label Oct 20, 2022
@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Oct 21, 2022

Hi @oneserv-heuser,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop and 2.4.5 instances and the issue is reproducible on both the instances.Kindly refer screenshots.

Screenshot 2022-10-21 at 4 32 24 PM

Screenshot 2022-10-21 at 4 17 32 PM

Hence confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Area: Catalog Component: TaxGraphQl Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 21, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Oct 21, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6883 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Oct 21, 2022

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Oct 25, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Oct 25, 2022
@serbynskyi
Copy link
Contributor

Hi @oneserv-heuser ! Try to test it using fixes from #36036

@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for grooming labels Apr 17, 2023
@github-jira-sync-bot github-jira-sync-bot removed the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 25, 2023
@github-jira-sync-bot github-jira-sync-bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 25, 2023
@m2-community-project m2-community-project bot added Progress: ready for dev and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Apr 25, 2023
@mGGk-fr
Copy link

mGGk-fr commented Jul 15, 2024

Hi 👋
I'm having the same issue on Magento 2.4.6, any update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Catalog Component: TaxGraphQl Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for grooming Reported on 2.4.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
  
Ready for Development
Development

No branches or pull requests

6 participants