Newsletter (un)subscription sent after changing email address

[Axel29]

Preconditions and environment

• Magento 2.4.3-p3

Steps to reproduce

1. Create a customer account
2. Subscribe to the newsletter
3. Change customer email address

Expected result

1. The email address changed email is sent to the customer
2. No other email than the email address update confirmation is sent.

Actual result

1. The customer recieves both email changed AND newsletter subscription confirmation email.

The bug is simply that there should not be a subscription or unsubscription confirmation email sent when changing the customer email address.

The action of changing a customer account's email address has absolutely nothing to do with the newsletter whatsoever, and it is more than confusing to recieve a subscription confirmation email when I simply change my email address...

Additional information

This bug seems to be introduced in commit 47e3ada on the class \Magento\Newsletter\Model\Plugin\CustomerPlugin with the following line:

return $customer->getEmail() !== $subscriber->getEmail() || (int)$subscriber->getCustomerId() === 0;

This is because when changing the email, the customer gets saved, triggering this Plugin and then the method suggests that the email should be sent but this has no sense.

Also, the same bug occurs if the customer is unsubscribed from the newsletter.
In this case, the email sent when changing the customer's email is not the subscription confirmation but the unsubscribe confirmation.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Axel29. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
     Details

     If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Dash, here is your Magento Instance: https://6e6c553486348bbc4d18f26bd2e4872a.instances.magento-community.engineering
Admin access: https://6e6c553486348bbc4d18f26bd2e4872a.instances.magento-community.engineering/admin_65d9
Login: f79bbbd1
Password: cbab449e6d4f

[engcom-Dash]

Hi @Axel29 ,

We are Worked this issue in magento 2.4.4 instance...We are able to reproduce the issue with respective results.

Pre condition:
Magento version 2.4.4
PHP 8.1

Steps to reproduce:
1.Install magento instance
2.Login with customer email
3.Subscribe the newsletter with Same Email id
4.Trying to change the email in store front end
5.Email changed successfully

While subscribe the current email id i received subscription mail as well as while changing the customer email i received the subscription email id.
we are getting actual result...so we are confirming the issue.

Screenshots:

Let us know if we missing anything

Thanks!!!

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

❌ Something went wrong. Cannot create Jira issue.

[Axel29]

Hi @engcom-Dash ,

I edited the post to make it more clear.

The bug is simply that there should NEVER be a subscription or unsubscription confirmation email sent when changing the customer email address.

The action of changing my account's email address has absolutely nothing to do with the newsletter whatsoever, and it is more than confusing to recieve a subscription confirmation email when I simply change my email address...

Hoping this is more clear this way.

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Dash, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Dash, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[engcom-Dash]

Hi @Axel29 ,

Thanks for your contribution and information.....

We got email address which is received when customer change the customer email address as well as we didn't receive any subscription related email when customer changing the email address.

Thanks!!!!

[engcom-Lima]

✔️ Issue confirmed

Issue got reproduced in 2.4-develop branch.

Description: Newsletter (un)subscription sent after changing email address.

Pre-requisite:

• Fresh magento 2.4-develop should be installed.

Steps to reproduce:

1. Create a customer account
2. Subscribe to the newsletter
3. Change customer email address

Expected result:

1. The email address changed email is sent to the customer
2. No other email than the email address update confirmation is sent.

Actual result:
The customer recieves both email changed AND newsletter subscription confirmation email.

Screenshots:

[m2-assistant]

Hi @engcom-Lima. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[github-jira-sync-bot]

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-7091

[github-jira-sync-bot]

❌ You don't have permission to export this issue.