Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphQL] related, upsell and crosssell products query ignoring the position they were saved in #36461

Closed
1 of 5 tasks
MarianNapi opened this issue Nov 11, 2022 · 22 comments · May be fixed by #36485
Closed
1 of 5 tasks
Assignees
Labels
Area: Product Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@MarianNapi
Copy link

Preconditions and environment

  • Magento version 2.4.5

Steps to reproduce

  1. Create a product
  2. add other products as related, upsell or crosssell products and sort them in a random order
  3. Request these fields via the GraphQl API

Expected result

The related, upsell and crosssell products should be returned in the specific order they were saved in.

Actual result

The related, upsell and crosssell products are returned sorted by their actual product entity_id.

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Nov 11, 2022

Hi @MarianNapi. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@MarianNapi
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @MarianNapi. Thank you for your request. I'm working on Magento instance for you.

@engcom-Bravo engcom-Bravo self-assigned this Nov 11, 2022
@m2-assistant
Copy link

m2-assistant bot commented Nov 11, 2022

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.5 Indicates original Magento version for the Issue report. label Nov 11, 2022
@magento-deployment-service
Copy link

@MarianNapi
Copy link
Author

I can reproduce the issue on a vanilla magento instance with version 2.4-develop

@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Bravo
Copy link
Contributor

Hi @MarianNapi,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce
1.Create a product
2.add other products as related, upsell or crosssell products and sort them in a random order
3.Request these fields via the GraphQl API

The related, upsell and crosssell products are returned sorted by their actual product entity_id.

Simple-Products-Inventory-Catalog-Magento-Admin

Screenshot 2022-11-14 at 2 54 12 PM

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Area: Product Component: GraphQL GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 14, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Nov 14, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7014 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Nov 14, 2022

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented Nov 15, 2022

@engcom-Bravo We need to check this functionality in the frontend as well. So please reverify it and let us know the outcome here.

@engcom-Hotel engcom-Hotel moved this from Confirmed to Ready for Confirmation in Issue Confirmation and Triage Board Nov 15, 2022
@engcom-Hotel engcom-Hotel removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Nov 15, 2022
@engcom-Hotel engcom-Hotel removed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: ready for confirmation labels Nov 15, 2022
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Nov 15, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Nov 17, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in High Priority Backlog Mar 20, 2023
@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: dev in progress and removed Progress: dev in progress labels Mar 20, 2023
@m2-community-project m2-community-project bot removed the Progress: PR Created Indicates that Pull Request has been created to fix issue label Mar 21, 2023
@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: dev in progress labels Mar 24, 2023
@engcom-November
Copy link
Contributor

Hi @MarianNapi ,
Development team is currently working on this issue.
Thank you.

@m2-community-project m2-community-project bot removed the Progress: PR Created Indicates that Pull Request has been created to fix issue label May 4, 2023
@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: dev in progress labels May 5, 2023
@engcom-Bravo
Copy link
Contributor

Hi @MarianNapi,

Verified the issue on Magento 2.4-develop instance and the issue is no longer reproducible.Hence we are closing this issue.

Thanks.

@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in High Priority Backlog May 9, 2023
@m2-community-project m2-community-project bot added Progress: done and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels May 9, 2023
@MarianNapi
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @MarianNapi. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@Xeo67
Copy link

Xeo67 commented Sep 28, 2023

Is there a fix ? I have the same issue on Magento 2.4.5-p4

There is no sorting on position attribute when Magento search the relation in vendor/magento/module-related-product-graph-ql/Model/DataProvider/RelatedProductDataProvider.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Product Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

7 participants