Default V6 VCL Template Logic

[icecactus]

Preconditions and environment

v2.4.5

Steps to reproduce

Navigate to a page that does a 301 redirect or has "private" in cache-control header with a status code of 200.

Expected result

I would think anything (200, 404, 301 etc) that has "private" in Cache-Control header would not get cached.

Actual result

https status 200 with private in Cache-Control header is now cached and a 301 is also now cached unless it has private in Cache-Control header.

Additional information

From #6150231 File: app/code/Magento/PageCache/etc/varnish6.vcl

Previous versions of generated VCL

# cache only successfully responses and 404s
    if (beresp.status != 200 && beresp.status != 404) {
        set beresp.ttl = 0s;
        set beresp.uncacheable = true;
        return (deliver);
    } elsif (beresp.http.Cache-Control ~ "private") {

New V6 generated VCL

# cache only successfully responses and 404s that are not marked as private
    if (beresp.status != 200  &&
            beresp.status != 404 &&
            beresp.http.Cache-Control ~ "private") {
        set beresp.uncacheable = true;
        set beresp.ttl = 86400s;
        return (deliver);

The logic changed on v6. Perhaps I misunderstand but shouldn't it be
if ((beresp.status != 200 && beresp.status != 404) || (beresp.http.Cache-Control ~ "private")) {

Im running into an issue with a 3rd party module where it no longer works correctly due to this change.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @icecactus. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[hostep]

I think your remark makes sense. @gquintard what do you think?

[gquintard]

indeed, that should have been

if ((beresp.status != 200 && beresp.status != 404) || (beresp.http.Cache-Control ~ "private")) {

[github-jira-sync-bot]

❌ Something went wrong. Cannot create Jira issue.

[github-jira-sync-bot]

❌ Something went wrong. Cannot create Jira issue.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10944 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Echo. Thank you for verifying the issue.
Issue Available: @engcom-Echo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.