-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creditmemo for an order that contains only one configurable product is not generated correctly #36722
Comments
Hi @leonhelmus. Thank you for your report.
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
For more details, review the Magento Contributor Assistant documentation. Add a comment to assign the issue: To learn more about issue processing workflow, refer to the Code Contributions.
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @engcom-November. Thank you for working on this issue.
|
@magento give me 2.4-develop instance |
Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-November, here is your Magento Instance: https://5beb5ba2d681cafd8b3ec0530ac4dbd7.instances.magento-community.engineering |
@magento give me 2.4-develop instance |
Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-November, here is your Magento Instance: https://5beb5ba2d681cafd8b3ec0530ac4dbd7.instances.magento-community.engineering |
Verified the issue on Magento 2.4-develop instance and the issue is reproducible with the steps mentioned in the description. Hence confirming this issue. |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-7632 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-November. Thank you for verifying the issue. |
❌ You don't have permission to export this issue. |
@engcom-November thanks for confirming the issue as soon as you did! |
Closed without explanation why? Probably fixed by BUG#7632: Creditmemo for an order that contains only one configurable product is not generated correctly |
Preconditions and environment
Functionality to check if its the last creditmemo does not work correctly. It's a similar issue like:
#31143
Steps to reproduce
When calling the function isLast() to check if this is the last creditmemo:
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Sales/Model/Order/Creditmemo.php#L562
It also checks the dummy items while this should be skipped. This is the same issue as described in #31143 same resolution also works for creditmemo.
Expected result
if all products of configurable are refunded it the function isLast() should return a true.
Actual result
if all products of configurable are refunded it the function isLast() should return a false, because of the dummy items.
Additional information
Patch to resolve the issue. Same resolution can be found here:
#31472
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: