Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magento Cloud] There is a problem with the magento report order screen #36742

Closed
github-jira-sync-bot opened this issue Jan 13, 2023 · 6 comments
Assignees
Labels
Evaluated Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@github-jira-sync-bot
Copy link

ISSUES:
Wrong data in REPORTS>Sales>Orders if website currency is different than default one

STEPS TO REPLICATE:

  • Install clean 2.4-develop
  • Go to Stores > Config > Catalog > Catalog > Price and set:
    -- Catalog Price Scope = Website
  • Create an additional Website, Store and Store view
  • Go to Stores > Config > General > Currency Setup > Currency Options and set:
    -- Default Config:
    --- Base Currency: USD
    --- Default Display Currency : USD
    --- Allowed Currencies: EUR, USD and THB (Thai Baht)
    -- Main Website:
    --- Base Currency: EUR
    --- Default Display Currency : EUR
    --- Allowed Currencies: EUR
    -- Additional new Website:
    --- Base Currency: THB (Thai Baht)
    --- Default Display Currency : THB (Thai Baht)
    --- Allowed Currencies: THB (Thai Baht)
  • Go to Stores > Currency > Currency Rates and set the empty conversion rates for the THB (set rates to 1.0000)
  • Create a product, assign it to both websites, and place an order with this product in the additional Website previously created
  • Make sure that the order is in status Processing (invoice it)
  • In the backend, go to Reports > Sales > Orders
  • Click on the Yellow warning to refresh the statistics
  • Set the scope of the report on the additional website previously created and set the filter as following:
    -- Date Used: created
    -- Period: day
    -- From and To: the same day of when the test order was placed
    -- Order Status: any
    -- Empty rows: No
    -- Show Actual Values: No

ACTUAL RESULT:

  • The totals are zero

EXPECTED RESULT:

  • Sales Total should show the total of the placed order, converted in the currency of the website

ADDITIONAL NOTES:

  • If we change the scope of the report and set it to "All Websites", the totals are shown correctly
  • During my debugging, I identified that the issue is related to app/code/Magento/Reports/Block/Adminhtml/Grid/Column/Renderer/Currency.php, method getStoreCurrencyRate
@github-jira-sync-bot github-jira-sync-bot added Evaluated Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 13, 2023
@github-jira-sync-bot
Copy link
Author

The issue was exported from the internal Jira. The link to the original Jira issue: https://jira.corp.adobe.com/browse/ACP2E-1541

@m2-assistant
Copy link

m2-assistant bot commented Jan 13, 2023

Hi @github-jira-sync-bot. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Jan 13, 2023

Hi @o-iegorov. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Jan 13, 2023
@o-iegorov
Copy link
Contributor

Internal team start working on the issue

@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Jan 20, 2023
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Jan 31, 2023
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Jan 31, 2023
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Feb 1, 2023
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Feb 1, 2023
@chittima
Copy link
Contributor

chittima commented Mar 6, 2023

commit id: 993e00c

@chittima
Copy link
Contributor

chittima commented Mar 6, 2023

Issue already fixed. Here is the commit id 993e00c

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Evaluated Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Development

No branches or pull requests

3 participants