Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4.5-p1] PayPal Express Checkout - Missing SKU & Full product [variation] title #36808

Closed
1 of 5 tasks
FadedOut opened this issue Feb 5, 2023 · 20 comments · Fixed by #37578
Closed
1 of 5 tasks

[2.4.5-p1] PayPal Express Checkout - Missing SKU & Full product [variation] title #36808

FadedOut opened this issue Feb 5, 2023 · 20 comments · Fixed by #37578
Assignees
Labels
Area: Payments Component: Paypal feature request Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@FadedOut
Copy link

FadedOut commented Feb 5, 2023

Preconditions and environment

  • Magento 2.4.5-p1
  • PHP8.1
  • PayPal Express Checkout (Sandbox or Live) (the included extension)

Steps to reproduce

  1. Enable PayPal Express Checkout [sandbox or live, the result is the same so just do sandbox for this test]
  2. Enable "Transfer Cart Line Items"
  3. Enable "PayPal Guest Checkout"
  4. Submit Order (by credit card using a test number provided HERE). It is the same end result using a PayPal personal account but for testing purposes just use a test credit card for easier testing.
  5. Check PayPal transaction in PayPal sandbox account (not Magento)

Expected result

When viewing the PayPal transaction in the PayPal account, it should say one of the following:

-Men's T-Shirt-Red, S
-Men's T-Shirt-Red, M
-Men's T-Shirt-Red, L
-Men's T-Shirt-Red, XL

For instance, it should say "SKU 12345678 | Men's T-Shirt-Red, M | QTY 5". It should also show (or have) the SKU included with the line item.

Pretty sure WooCommerce does exactly that so I'm pretty certain PayPal is capable of taking that information.

Actual result

Neither are there. What actually shows is this:

Men's T-Shirt QTY 5

That is it. I will attach a screenshot of what I mean. There is no SKU with the item nor is the correct/actual item listed. It simply lists the parent product (Men's T-Shirt) when it was one of it's variants that was purchased (like Red, M or Red, L, etc.). The Magento order transaction page shows all that. But it's like it's not sending it to PayPal?

I just noticed this important missing information. It's very important when it comes to transaction logs and doing taxes. As I am now just noticing this, I realize this is going to be a disaster when doing taxes as there is no real way of me knowing what the COGS was (having no SKU or proper product title I can't sync it to a costs sheet and figure out what my actual net revenue was).

magento-245p1-paypal-missing-sku-product-title-details-screenshot-1

Additional information

I will test this on a 2.4-dev instance and see but I don't think it will change - it seems like it might have been like this for a long time now.

Thank you in advance. Hopefully someone can point me to a fix for this so I can get my transaction logs reporting correctly.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Feb 5, 2023

Hi @FadedOut. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@FadedOut
Copy link
Author

FadedOut commented Feb 5, 2023

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @FadedOut. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@FadedOut
Copy link
Author

FadedOut commented Feb 5, 2023

Appears to be the same result. Will not show the SKU or variation title.

@engcom-Hotel engcom-Hotel added the Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. label Feb 6, 2023
@m2-assistant
Copy link

m2-assistant bot commented Feb 6, 2023

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.

  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Alfa
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Alfa
Copy link
Contributor

@magento give me 2.4-develop instance with extensions magento/Payment methods

@magento-deployment-service
Copy link

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Alfa
Copy link
Contributor

@magento give me 2.4-develop instance with extensions payment methods/PayPal Express

@magento-deployment-service
Copy link

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Feb 7, 2023

Hi @FadedOut

Thanks for reporting the ticket.

as per retesting, we found the same output in the Paypal Sandbox link according to the below snapshot.
but since it is a change request instead of a bug hence the ticket is updated with the feature request label.

Attachmentissues:36808

@aasim110
Copy link
Contributor

aasim110 commented Jun 4, 2023

@magento I'm working on this

@FadedOut
Copy link
Author

FadedOut commented Jun 5, 2023

@aasim110

Thank you for taking up this task. I think it's an incredible oversight not to have Magento send this information to PayPal for proper record keeping in PayPal (revenue reporting). I don't know how others work around this missing information while using PayPal.

@m2-community-project m2-community-project bot added Progress: PR in progress Priority: P3 May be fixed according to the position in the backlog. labels Jun 5, 2023
@engcom-Lima engcom-Lima added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Paypal Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Payments labels Jul 13, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9142 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Jul 13, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot github-jira-sync-bot added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Aug 21, 2023
@m2-community-project m2-community-project bot moved this from Pull Request in Progress to Done in Feature Requests Backlog Aug 31, 2023
@m2-community-project m2-community-project bot added Progress: done and removed Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Payments Component: Paypal feature request Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

6 participants