Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Fix - Newrelic GraphQl transaction names not working #36874

Closed
2 of 5 tasks
m2-assistant bot opened this issue Feb 16, 2023 · 5 comments · Fixed by #36436
Closed
2 of 5 tasks

[Issue] Fix - Newrelic GraphQl transaction names not working #36874

m2-assistant bot opened this issue Feb 16, 2023 · 5 comments · Fixed by #36436
Assignees
Labels
Area: Framework Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Feb 16, 2023

This issue is automatically created based on existing pull request: #36436: Fix - Newrelic GraphQl transaction names not working


Description (*)

Add transaction names to all new relic graphql transactions.

So many other transactions are properly named without having the newrelicreporting/general/enable=1 flag set.

Currently graphql works like this

  • graphql ( handled by magento php level, so long as the php extension is enabled, and the magento extension is enabled with newrelicreporting/general/enable=1 )

Having to enable this new relic reporting module to get GraphQL transaction names seems like a bit of an oversight. It is perfectly viable to have this setup

  1. install new relic in the php.ini level, new relic will auto detect that it is magento2
; Setting: newrelic.framework
; Type   : string
; Scope  : per-directory
; Default: empty (auto-detect framework)
; Info   : Disables automatic framework detection, telling the agent to
;          attempt to name transactions according to the specified framework.
;          Specifying "no_framework" will disable framework-related transaction
;          naming entirely. Please let us know at support.newrelic.com if you
;          encounter a failure with framework autodetection.
;
;          Must be one of the following values:
;          cakephp, codeigniter, drupal, drupal8, joomla, kohana, laravel,
;          magento, magento2, mediawiki, silex, slim, symfony1, symfony2,
;          wordpress, yii, zend, zend2, no_framework
;
;          Note that "drupal" covers only Drupal 6 and 7.
;
;newrelic.framework = ""
  1. Do not enable the magento extension, set newrelicreporting/general/enable=0
  2. Expect to see transaction names for graphql

What we actually see is

/FrontController/Magento\GraphQl\Controller\GraphQl\Interceptor

Related Pull Requests

Manual testing scenarios (*)

  1. Configure new relic in your php.ini
  2. Make a graphql request like https://example.com/graphql?luker=3&query=%257Bproducts(filter%253A%257Bsku%253A%257%5B%25E2%2580%25A6%5DA%2522nonsuchsku%2522%257D%257D)%257Bitems%257Bname%2520sku%257D%257D%257D
  3. See Graphql-products in your new relic transactions list

Screenshot 2022-11-08 at 15 24 31

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 16, 2023
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Feb 16, 2023
@engcom-Alfa engcom-Alfa added Component: GraphQL GraphQL Area: Framework Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Feb 16, 2023
@engcom-Alfa
Copy link
Contributor

hey

as per discussion with the internal team confirming the ticket.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 16, 2023
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@engcom-Alfa engcom-Alfa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 16, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7974 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Feb 16, 2023

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-November
Copy link
Contributor

Hi @engcom-Alfa ,
We are closing this issue as this is a duplicate of this ongoing confirmed issue. Kindly move on to this issue for latest updates / solutions on the same.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

4 participants