Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tax Class set to None when creating new configurable variations in multi store mode #37180

Closed
1 of 5 tasks
dphilipps opened this issue Mar 10, 2023 · 11 comments
Closed
1 of 5 tasks
Labels
Area: Tax Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@dphilipps
Copy link

dphilipps commented Mar 10, 2023

Preconditions and environment

Magento 2.4.5-p1
Multi store (Two stores, each with its own website)

When creating new variations of an existing configurable product in Store View Scope, the 'tax class' value in the new simple products is set to 'None' instead of the value set in the parent (the configurable). This results in no tax being added to these products in the cart and under charging customers for tax.

When creating a NEW configurable product, the initial child products are created correctly, with 'tax class' set as per the parent.

This bug is not present in single store mode or when creating new variations in 'All Store Views' scope.

This is present in a fresh multi store install of Magento 2.4.5-p1 with the Luma demo store.

Steps to reproduce

  1. Ensure multi store is enabled (with at least 2 stores configured)
  2. On product grid set filter Store View: Default Store View
  3. Create a Configurable product with 'tax class' = 'taxable goods'
  4. Edit Configurations
  5. Confirm scope setting 'Scope: Default Store View'
  6. Create variations and child products
  7. Save product
  8. Verify child products have 'tax class' = 'taxable goods'
  9. Edit the configurable product and 'Edit Configurations' to create new variations
  10. Save product
  11. Check new child products 'tax class'

Expected result

New child product 'tax class' should be 'taxable goods'

Actual result

New child product 'tax class' is 'none' at 'All store views' and 'Default store views' scopes.

Additional information

I have verified this on current ver. dev-develop:

https://www.loom.com/share/cc6429e224cb4443b84674fc94e5dbb3

This is a very serious issue as store administrators may not notice child products are created with no tax class set, resulting in customers making purchases without tax being added at checkout and the merchant suffering a shortfall in the amount of tax collected for the order.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Mar 10, 2023

Hi @dphilipps. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@dphilipps
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @dphilipps. Thank you for your request. I'm working on Magento instance for you.

@engcom-Bravo engcom-Bravo self-assigned this Mar 10, 2023
@m2-assistant
Copy link

m2-assistant bot commented Mar 10, 2023

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. label Mar 10, 2023
@magento-deployment-service
Copy link

@dphilipps
Copy link
Author

Video demonstrating the issue on the above develop instance.

https://www.loom.com/share/cc6429e224cb4443b84674fc94e5dbb3

@dphilipps dphilipps changed the title Tax Class not set when creating new configurable variations in multi store mode Tax Class set to None when creating new configurable variations in multi store mode Mar 10, 2023
@engcom-Bravo
Copy link
Contributor

Hi @dphilipps,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Ensure multi store is enabled (with at least 2 stores configured)
  • On product grid set filter Store View: Default Store View
  • Create a Configurable product with 'tax class' = 'taxable goods'
  • Edit Configurations
  • Confirm scope setting 'Scope: Default Store View'
  • Create variations and child products
  • Save product
  • Verify child products have 'tax class' = 'taxable goods'
  • Edit the configurable product and 'Edit Configurations' to create new variations
  • Save product
  • Check new child products 'tax class'

Screenshot 2023-03-10 at 5 41 10 PM

Screenshot 2023-03-10 at 5 41 35 PM.

Screenshot 2023-03-10 at 6 03 32 PM

Screenshot 2023-03-10 at 6 03 57 PM

Child Products are created with Tax class as None.In frontend tax is not applying to the products.

Hence confirming this issue.

Thanks.

@engcom-Bravo engcom-Bravo added Area: Tax Component: Tax Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 10, 2023
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Mar 10, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-8227 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Mar 10, 2023

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@dphilipps
Copy link
Author

Thanks for the prompt confirmation of the issue @engcom-Bravo

@engcom-Hotel engcom-Hotel added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Mar 14, 2023
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Mar 14, 2023
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Apr 26, 2023
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Apr 26, 2023
@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: dev in progress labels May 2, 2023
@dphilipps
Copy link
Author

dphilipps commented May 22, 2023

Good news a PR has been created. Could you please provide a link to the PR @engcom-Hotel ?

@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in High Priority Backlog May 22, 2023
@m2-community-project m2-community-project bot removed the Progress: PR Created Indicates that Pull Request has been created to fix issue label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tax Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

No branches or pull requests

4 participants