Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Fix image order when 10+ images on dropdown configurable products #37285

Closed
4 of 5 tasks
m2-assistant bot opened this issue Mar 23, 2023 · 2 comments · Fixed by #37282
Closed
4 of 5 tasks

[Issue] Fix image order when 10+ images on dropdown configurable products #37285

m2-assistant bot opened this issue Mar 23, 2023 · 2 comments · Fixed by #37282
Labels
Area: Product Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Mar 23, 2023

This issue is automatically created based on existing pull request: #37282: Fix image order when 10+ images on dropdown configurable products


Description (*)

This PR fixes an images order, which was described mostly in this issue #22249 and fixed in this commit 700a153

The same issue appears for products using the Dropdown attribute types (not swatches)

Related Pull Requests

Manual testing scenarios (*)

  1. Install Magento with sample data
  2. Update 2 attributes color and size to use Dropdown as "Catalog Input Type for Store Owner"
  3. Upload more than 10 images to WJ12-XS-Blue product
  4. On configurable product page that images should have correct order

Questions or comments

Does it need new issue?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 23, 2023
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Mar 23, 2023
@engcom-Lima engcom-Lima added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Component: Frontend Area: Product labels Mar 24, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-8345 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Mar 24, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Product Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

2 participants