Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Add input-file argument to varnish:vcl:generate #37363

Closed
2 of 5 tasks
m2-assistant bot opened this issue Apr 11, 2023 · 2 comments · Fixed by #36538
Closed
2 of 5 tasks

[Issue] Add input-file argument to varnish:vcl:generate #37363

m2-assistant bot opened this issue Apr 11, 2023 · 2 comments · Fixed by #36538
Assignees
Labels
Area: Framework Component: Cache Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2023

This issue is automatically created based on existing pull request: #36538: Add input-file argument to varnish:vcl:generate


This pull request allows us to pass in a path to a custom modified VCL file relative to the Magento root. This way, we can add our own custom VCL to our Git repo and generate it on deploy using a default Magento command.

Manual testing scenarios (*)

  1. Install clean Magento
  2. Copy the core Varnish file into app/etc
  3. Modify the file. For testing purposes, we append # TEST
  4. Generate the VCL using the new input-file argument
  5. The generated VCL is shown in stdout, and you should see # TEST at the end of the output of the previous command.

Copy & paste;

cp vendor/magento/module-page-cache/etc/varnish6.vcl app/etc/varnish6.vcl
echo "# TEST" >> app/etc/varnish6.vcl
bin/magento varnish:vcl:generate --input-file=app/etc/varnish6.vcl --export-version=6

Questions or comments

If someone could tell me for which scenarios to write a unit test, I'll try to do my best.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P3 May be fixed according to the position in the backlog. label Apr 11, 2023
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Apr 11, 2023
@engcom-Lima engcom-Lima added Component: Cache Area: Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. labels Apr 11, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-8502 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Apr 11, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: Cache Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

3 participants