[Issue] Cleanup of some non-existing classes from some unit tests code in the…

[m2-assistant]

This issue is automatically created based on existing pull request: #37629: Cleanup of some non-existing classes from some unit tests code in the…

---

… Magento framework.

Description (*)

In an attempt at slowly fixing phpstan reported issues in the entire Magento codebase, I took a look today at the Framework code and searched for classes used that don't exist (any more). I've only found some fixes for some unit tests in the Framework code. This fixes 7 errors out of 173 phpstan errors found in total when scanning on level 0 on the Framework code.

Errors fixed:

 ------ ---------------------------------------------------------------------------- 
  Line   internal/Magento/Framework/Filesystem/Test/Unit/File/ExcludeFilterTest.php  
 ------ ---------------------------------------------------------------------------- 
  55     Class SplFileInfoClass not found.                                           
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols         
 ------ ---------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------- 
  Line   internal/Magento/Framework/ObjectManager/Test/Unit/Factory/CompiledTest.php  
 ------ ----------------------------------------------------------------------------- 
  302    Class Magento\Framework\ObjectManager\Test\Unit not found.                   
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols          
  308    Class Magento\Framework\ObjectManager not found.                             
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols          
 ------ ----------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   internal/Magento/Framework/ObjectManager/Test/Unit/Helper/SortItemsTest.php                                                                                                                      
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  18     Property Magento\Framework\ObjectManager\Test\Unit\Helper\SortItemsTest::$_itemInterpreter has unknown class Magento\Framework\ObjectManager\Test\Unit\Helper\InterpreterInterface as its type.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                              
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

------ ---------------------------------------------------------------------- 
  Line   internal/Magento/Framework/Pricing/Test/Unit/Render/PriceBoxTest.php  
 ------ ---------------------------------------------------------------------- 
  77     Class Magento\Store\Model\Store\Config not found.                     
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
 ------ ---------------------------------------------------------------------- 

------ ------------------------------------------------------------------------ 
  Line   internal/Magento/Framework/TestFramework/Unit/Helper/ObjectManager.php  
 ------ ------------------------------------------------------------------------ 
  163    Class Magento\Framework\Api\Builder not found.                          
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols     
 ------ ------------------------------------------------------------------------ 

------ -------------------------------------------------------------------------------------- 
  Line   internal/Magento/Framework/Webapi/Test/Unit/Rest/Request/DeserializerFactoryTest.php  
 ------ -------------------------------------------------------------------------------------- 
  65     Class Magento\Framework\Webapi\Response\Rest\Renderer\Json not found.                 
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                   
 ------ -------------------------------------------------------------------------------------- 

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

1. Run: vendor/bin/phpstan clear-result-cache && bin/magento setup:di:compile && composer dump-autoload
2. Run: vendor/bin/phpstan analyse --level=0 lib/
3. After applying the changes from this PR and re-running steps 1 and 2 from above, you should have 7 fewer errors.
4. Also check if after these changes, all unit tests keep running correctly (but the automated tests on github should take care of testing this).

Questions or comments

It is my hope that it's Adobe's goal one day to have zero issues that phpstan finds on level 0, since those are the most important ones to fix usually. If we finally have level 0 tackled across the entire codebase, we can slowly go up one by one which would also allow the checks in pull requests here to be made against a higher level than only 0, which in the end should hopefully result in a lot more stable code then what we have right now.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9035 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.