Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAV attribute backend model 'ArrayBackend' filters non numeric values #37675

Closed
1 of 5 tasks
DiskoPete opened this issue Jun 27, 2023 · 12 comments · May be fixed by #37677
Closed
1 of 5 tasks

EAV attribute backend model 'ArrayBackend' filters non numeric values #37675

DiskoPete opened this issue Jun 27, 2023 · 12 comments · May be fixed by #37677
Assignees
Labels
Issue: On Hold Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.6 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@DiskoPete
Copy link

Preconditions and environment

  • Magento ^2.4.6

Steps to reproduce

  1. Create a new product attribute eg 'foobar' with
  • a \Magento\Eav\Model\Entity\Attribute\Backend\ArrayBackend backend model
  • a custom source model which has non numeric option values
  1. Save the product with changed attribute 'foobar' values (eg through a REST API call)

Expected result

Changed/new attribute values are saved to the product.

Actual result

Attribute values are not saved

Additional information

The non numeric values are filtered here and won't be saved:
https://github.com/magento/magento2/blob/2.4.6/app/code/Magento/Eav/Model/Entity/Attribute/Backend/ArrayBackend.php#L67

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jun 27, 2023

Hi @DiskoPete. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@DiskoPete
Copy link
Author

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Jun 27, 2023

Hi @DiskoPete! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@DiskoPete
Copy link
Author

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Jun 27, 2023

Hi @DiskoPete! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@DiskoPete
Copy link
Author

@magento I am working on this

@engcom-Bravo engcom-Bravo added Reported on 2.4.6 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it labels Jun 27, 2023
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 28, 2023
@engcom-November engcom-November self-assigned this Jul 25, 2023
@m2-assistant
Copy link

m2-assistant bot commented Jul 25, 2023

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Jul 25, 2023
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Jul 25, 2023
@engcom-November
Copy link
Contributor

Hello @DiskoPete,

Thank you for reporting and collaboration!

We have tried to reproduce the issue on 2.4-develop, We found that the custom attribute value is not being saved and is being deleted when we try to change the value from REST API call, There is already an issue on Custom attribute being deleted.
The issue is open, Please refer to #37426 for more information.

You can refer the below screenshots
image
image

After using PUT to change custom attribute value, The custom attribute is being deleted.
image
image

Hence putting the Issue on hold.
Please let us know if we are missing something.

Thanks.

@DiskoPete
Copy link
Author

Hi @engcom-November

Thanks for your feedback.
I agree that the mentioned issue is connected.

The fix I prepared will probably also solve the other issue.
#37677

@abukatar
Copy link
Contributor

Hello @DiskoPete

Thank you for your contribution and collaboration!

An internal Magento team is working on this issue right now (as Jira ticket ACP2E-2647).

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 29, 2023
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 29, 2023
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Nov 30, 2023
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Nov 30, 2023
@abukatar
Copy link
Contributor

abukatar commented Dec 1, 2023

@magento I'm working on it

@asim-blueprintprep
Copy link
Contributor

This ticket is closed, but the linked MR is still open...does anyone have a link the the MR that fixed this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: On Hold Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.6 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
6 participants