Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Fix missing jQuery widget dependency #37683

Closed
5 tasks
m2-assistant bot opened this issue Jun 28, 2023 · 2 comments · Fixed by #37302
Closed
5 tasks

[Issue] Fix missing jQuery widget dependency #37683

m2-assistant bot opened this issue Jun 28, 2023 · 2 comments · Fixed by #37302
Assignees
Labels
Area: UI Framework Component: Framework/RequireJs Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jun 28, 2023

This issue is automatically created based on existing pull request: #37302: Fix missing jQuery widget dependency


Description (*)

When the JS bundling is enabled, and the trim input js file isn't in the bundle, on the 1st page-view we're getting JS error caused by missing $.widget function.
image

bundle-common.min.js:1 TypeError: $.widget is not a function
    at trim-input.min.js:1:46
    at Object.execCb (require.min.js:117:195)
    at i.execCb (bundle-common.min.js:1:525685)
    at Module.check (require.min.js:59:418)
    at Module.enable (require.min.js:77:285)
    at Module.init (require.min.js:57:144)
    at callGetModule (require.min.js:78:238)
    at Object.completeLoad (require.min.js:110:1)
    at HTMLScriptElement.onScriptLoad (require.min.js:117:393)

My Pull Request fixes this issue by declaring a missing dependency to jquery widget.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 28, 2023
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Jun 28, 2023
@engcom-Lima engcom-Lima added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Framework/RequireJs Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: UI Framework labels Jul 5, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9115 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Jul 5, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI Framework Component: Framework/RequireJs Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

3 participants