Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Add aspect ratio for catalog images and remove unnecessary script #37691

Closed
m2-assistant bot opened this issue Jun 30, 2023 · 2 comments · Fixed by #34776
Closed

[Issue] Add aspect ratio for catalog images and remove unnecessary script #37691

m2-assistant bot opened this issue Jun 30, 2023 · 2 comments · Fixed by #34776
Assignees
@in-session
Labels
Area: UI Framework Component: Catalog Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Low Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jun 30, 2023

This issue is automatically created based on existing pull request: #34776: Add aspect ratio for catalog images and remove unnecessary script

Description (*)

The old CSS hack could be modernised here, also remove inlinescript.
https://caniuse.com/mdn-css_properties_aspect-ratio

Testet also on Safari 14.0.3 (fallback)
apple
@m2-assistant m2-assistant bot added Component: Catalog Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jun 30, 2023
@m2-assistant m2-assistant bot mentioned this issue Jun 30, 2023
Merged
1 task
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Jun 30, 2023
@engcom-Lima engcom-Lima added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Component: Frontend Area: UI Framework labels Jul 3, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9109 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Jul 3, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot github-jira-sync-bot added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Aug 21, 2023
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Low Priority Backlog Aug 31, 2023
@m2-community-project m2-community-project bot removed Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@in-session in-session

Labels
Area: UI Framework Component: Catalog Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Low Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add aspect ratio for catalog images and remove unnecessary script in-session/magento2
3 participants
@in-session @engcom-Lima @github-jira-sync-bot