Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Fixed typo in unit test introduced by accident in e0c61dee13afcd10c03… #37792

Closed
2 of 5 tasks
m2-assistant bot opened this issue Jul 24, 2023 · 2 comments · Fixed by #37785
Closed
2 of 5 tasks

[Issue] Fixed typo in unit test introduced by accident in e0c61dee13afcd10c03… #37792

m2-assistant bot opened this issue Jul 24, 2023 · 2 comments · Fixed by #37785
Assignees
@hostep
Labels
Area: Test framework Component: Test Component: TestFramework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jul 24, 2023

This issue is automatically created based on existing pull request: #37785: Fixed typo in unit test introduced by accident in e0c61de…

…3803e344a22df10631eeb

Description (*)

Accidentally found by running phpstan on level 0 on the entire codebase. $this->attribute§('getIsUnique') is not really proper code.

It looks like this mistake was accidentally introduced in e0c61de#diff-220a7a1cb2d4bae1236aeeb318f8ae5368fb92017598c1db77fba6754d2cf9fa

I've also marked the test to no longer being skipped, it seems to run without any issues after this fix. I have no idea what is being mentioned in MAGETWO-48956?

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Run vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/Catalog/Test/Unit/Model/Category/Attribute/Backend/SortbyTest.php and make sure it doesn't output errors

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 24, 2023
@m2-assistant m2-assistant bot mentioned this issue Jul 24, 2023
Merged
6 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Jul 24, 2023
@engcom-Lima engcom-Lima added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Test Component: TestFramework Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Test framework labels Jul 25, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9194 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Jul 25, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hostep hostep

Labels
Area: Test framework Component: Test Component: TestFramework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed typo in unit test introduced by accident in e0c61dee13afcd10c03… hostep/magento2
3 participants
@hostep @engcom-Lima @github-jira-sync-bot