Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Log Aggregation fix on Checkout failure (group by reason, not Quote ID) #37879

Closed
5 tasks
m2-assistant bot opened this issue Aug 16, 2023 · 4 comments · Fixed by #37871
Closed
5 tasks

[Issue] Log Aggregation fix on Checkout failure (group by reason, not Quote ID) #37879

m2-assistant bot opened this issue Aug 16, 2023 · 4 comments · Fixed by #37871
Assignees
Labels
Area: Cart & Checkout Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 16, 2023

This issue is automatically created based on existing pull request: #37871: Log Aggregation fix on Checkout failure (group by reason, not Quote ID)


Description (*)

More and more projects use log aggregation tools - either self-hosted like Kibana, or SaaS like NewRelic or Sentry. These solutions are not able to aggregate log messages correctly, when these include unique data - such as event ID or Quote ID.

Event-specific details should be passed as a second attribute (context) of log method.

Before:
image

After

image

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Trigger Checkout failure
  2. Validate log message - It should not include any details

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Aug 16, 2023
@m2-community-project m2-community-project bot added Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Aug 16, 2023
@engcom-Hotel engcom-Hotel self-assigned this Aug 17, 2023
@m2-assistant
Copy link
Author

m2-assistant bot commented Aug 17, 2023

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Aug 17, 2023
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Aug 17, 2023
@engcom-Hotel
Copy link
Contributor

Hello @lbajsarowicz,

Thanks for the report and collaboration!

After going through the description it seems that the PR is not related to any bug in the core Magento file but we can consider it a good-to-have feature.

Hence marking this issue as a feature request.

Thanks

@m2-community-project m2-community-project bot added this to Pull Request in Progress in Feature Requests Backlog Aug 17, 2023
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in High Priority Backlog Aug 17, 2023
@engcom-Echo engcom-Echo added Area: Cart & Checkout Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 28, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9387 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Aug 28, 2023

✅ Confirmed by @engcom-Echo. Thank you for verifying the issue.
Issue Available: @engcom-Echo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Aug 28, 2023
@m2-community-project m2-community-project bot removed this from Pull Request in Progress in Feature Requests Backlog Aug 28, 2023
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Cart & Checkout Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

4 participants