Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magento Cloud] Bug of product custom option validation in product view page #38006

Closed
github-jira-sync-bot opened this issue Sep 22, 2023 · 8 comments
Labels
Evaluated Issue: ready for confirmation Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@github-jira-sync-bot
Copy link

github-jira-sync-bot commented Sep 22, 2023

Short issue description

->Message not displaying on When you press the Add to Cart button without first selecting a custom option, the first checkbox is highlighted, suggesting that you must first select one of the options before adding it to the cart.

Steps to reproduce

Go to the Admin
Catalog > Products > Edit a Product
Add Customizable options to the product - must be a checkbox option
Go to the PLP for the product
Do not select any custom option
Add product to cart

Actual results

No message appears to inform you to select a custom option

Expected results

message should appears to inform you to select a custom option

@github-jira-sync-bot github-jira-sync-bot added Evaluated Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 22, 2023
@github-jira-sync-bot
Copy link
Author

The issue was exported from the internal Jira. The link to the original Jira issue: https://jira.corp.adobe.com/browse/ACP2E-2404

@m2-assistant
Copy link

m2-assistant bot commented Sep 22, 2023

Hi @github-jira-sync-bot. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@m2-community-project m2-community-project bot added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 22, 2023
@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 22, 2023
@github-jira-sync-bot
Copy link
Author

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@m2-community-project m2-community-project bot moved this from Confirmed to Ready for Confirmation in Issue Confirmation and Triage Board Sep 22, 2023
@kestraly
Copy link

Just found this issue on a store today. No error message to select a custom option

@buhmann
Copy link

buhmann commented Oct 13, 2023

The problem is in the file \vendor\magento\module-catalog\view\frontend\web\product\view\validation.js Wrong position for "}" closing options, because of this methods are in the body of options.

@kestraly
Copy link

kestraly commented Oct 16, 2023

@buhmann - Appreciate you looking.

I can confirm. @buhmann is correct!
vendor/magento/module-catalog/view/frontend/web/product/view/validation.js

options: {
            radioCheckboxClosest: 'ul, ol',
+ },  // line 16

- } // line 88

@glo23503
Copy link
Contributor

Internal team is working on it

@chittima
Copy link
Contributor

chittima commented Dec 8, 2023

Here is the commit id:364d994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Evaluated Issue: ready for confirmation Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

No branches or pull requests

5 participants