Empty varchar attribute store level value wrong save in flat catalog

[hiren-gujarati]

Preconditions and environment

• Magento version: 2.4.6
• Multi store setup
• Enable Flat Catalog Product
• Indexer mode: Update by schedule
• Product attribute (backend_type: varchar, used_in_product_listing: true)

Steps to reproduce

1. Save varchar attribute value on global scope
2. Switch to store scope, uncheck Use Default Value checkbox and set empty/blank value in that varchar attribute
3. Check catalog_product_flat_{store_id} table after re-index data

You can see global scope value in the flat table instated of store scope value but in the EAV table (catalog_product_entity_varchar) you can see store scope value. When indexer mode is set to Update on save then catalog_product_flat_{store_id} table have store scope value.

Expected result

catalog_product_flat_{store_id} should have store scope value when Indexer mode is set Update by schedule.

Actual result

catalog_product_flat_{store_id} have global scope value when product have attribute value on store scope.

Additional information

Product flat re-indexer code have SQL query with getIfNullSql function which might replacing store scope null value with global scope value.
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Catalog/Model/Indexer/Product/Flat/TableBuilder.php#L333-L337

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @hiren-gujarati. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @hiren-gujarati,

Thanks for your reporting and Collaboration.

As per Magento devdocs https://experienceleague.adobe.com/en/docs/commerce-admin/catalog/catalog/catalog-flat Use of a flat catalog is no longer recommended as a best practice.

Could you please check document and let us know if you are still facing any issue.

Thanks.

[hiren-gujarati]

Hi @engcom-Bravo

As per Magento devdocs, flat catalog is not recommended as a best practice but Magento does not deprecated flat catalog yet.

There are issues related to this which is closed without any resolution,
#9434
#35499

Thanks.

[engcom-Bravo]

Hi @hiren-gujarati,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

catalog_product_flat_{store_id} getting store scope value when Indexer mode is set Update by schedule.

Kindly recheck the issue in Latest Magento 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

[hiren-gujarati]

Hi @engcom-Bravo

Seems like you didn't read description properly. I have clearly mentioned attribute which have backend_type varchar, You are checking on attribute with backend_type integer. Also please create store scope attribute, not a global.

Issue is reproducible from 2.1.x to latest Magento version 2.4.x. You can follow below step to reproduce issue.

1. Create global scope product attribute with backend_type varchar.
2. Set this attribute value (ex. test) from 'All store view' scope.
3. Switch to Store scope, uncheck Use Default Value checkbox and set empty/blank value in that attribute.
4. Flat product is enable from configuration and indexer is set on Update by schedule mode so, after 'indexer_update_all_views' cron run or manual reindex, catalog_product_flat_{store_id} table have 'All store view' value instned of store scope value.

Thanks.

[engcom-Bravo]

Hi @hiren-gujarati,

Thanks for your update.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

We are getting 'All store view' value instned of store scope value.

Hence Confirming the issue.

Thanks.

[hiren-gujarati]

Hi @engcom-Bravo

Thanks for checking and confirming issue.

I have created following patch for temporary workaround, not sure is it correct approach or not so, attaching patch.

--- a/vendor/magento/module-catalog/Model/Indexer/Product/Flat/TableBuilder.php
+++ b/vendor/magento/module-catalog/Model/Indexer/Product/Flat/TableBuilder.php
@@ -330,7 +330,8 @@
                         []
                     );

-                    $columnValue = $this->_connection->getIfNullSql(
+                    $columnValue = $this->_connection->getCheckSql(
+                        's' . $countTableName . '.value_id',
                         's' . $countTableName . '.value',
                         $countTableName . '.value'
                     );

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11715 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.