Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zend_Pdf not compatible with remote storage #38550

Open
1 of 5 tasks
Nuranto opened this issue Mar 25, 2024 · 7 comments
Open
1 of 5 tasks

Zend_Pdf not compatible with remote storage #38550

Nuranto opened this issue Mar 25, 2024 · 7 comments
Labels
Area: Framework Component: RemoteStorage Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@Nuranto
Copy link
Contributor

Nuranto commented Mar 25, 2024

Summary

Zend_Pdf is not compatible with remote storage.

Examples

$pdf = new \Zend_Pdf();
$pdf->save($remoteStoragePath);
\Zend_Pdf::load($remoteStoragePath);

Zend_Pdf uses fopen / fclose / etc... so it obviously fails when using remote storage.

Proposed solution

It seems laminas decided to drop pdf support, which leave us without simple solution.

Here are possible solutions :

  • Switch all PDF-related code to another library
  • Dev a cusom PDF library (but why reinvent wheel ?)
  • Improve/evolve current Zend_Pdf to fix compatibility issues.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@Nuranto Nuranto added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 25, 2024
Copy link

m2-assistant bot commented Mar 25, 2024

Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Mar 25, 2024
@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Mar 25, 2024
@engcom-Hotel engcom-Hotel self-assigned this Apr 1, 2024
Copy link

m2-assistant bot commented Apr 1, 2024

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel
Copy link
Contributor

Hello @Nuranto,

Thanks for the report and collaboration!

I would like to suggest that after save the PDF, use putObject (in case of S3) to upload file:

$pdf->save($pdf_file_path, true);

$s3Client = new S3Client([
    'version' => 'latest',
    'region' => $this->s3client_region,
    'credentials' => [
        'key'    => $this->s3client_key,
        'secret' => $this->s3client_secret,
    ],
]);


$key = 'test/data.pdf';

$result = $s3Client->putObject([
    'Bucket' => $this->s3client_bucket_name,
    'Key'    => $key,
    'Body'   => fopen($pdf_file_path, 'r'),
]);

// Check if the upload was successful
if ($result['@metadata']['statusCode'] === 200) {
    echo 'File uploaded successfully.';
} else {
    echo 'Failed to upload file.';
}

Does this resolve your issue? or have we missed anything here?

Thanks

@engcom-Hotel engcom-Hotel added Issue: needs update Additional information is require, waiting for response and removed Issue: ready for confirmation labels Apr 1, 2024
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Apr 1, 2024
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Apr 1, 2024
@Nuranto
Copy link
Contributor Author

Nuranto commented Apr 1, 2024

I already do have workarounds, it's just a shame we cannot use Zend_Pdf directly with remote storage instead of using workarounds.

At the moment, to load a pdf from remote storage, we have to first copy it to local storage. Or perhaps load contents from remote storage, and load pdf with content.
Same thing for saving, as you do in your proposed workaround.

When Zend_Pdf could simply load/save directly from/to remote storage.

I think since Magento2 took the decision to support Remote Storage, it should do it fully, not just for specific cases.

@engcom-Hotel
Copy link
Contributor

Thank @Nuranto for the quick reply!

I agree with your point, hence confirming the issue.

Thanks

@engcom-Hotel engcom-Hotel added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Component: RemoteStorage Area: Framework and removed Issue: needs update Additional information is require, waiting for response labels Apr 1, 2024
@m2-community-project m2-community-project bot added this to Dev In Progress in High Priority Backlog Apr 1, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11720 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Apr 1, 2024

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: RemoteStorage Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
High Priority Backlog
  
Ready for Development
Development

No branches or pull requests

4 participants