Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] User is not redirected when use_store is enabled and path is empty #38625

Open
5 tasks
m2-assistant bot opened this issue Apr 16, 2024 · 2 comments · May be fixed by #38616
Open
5 tasks

[Issue] User is not redirected when use_store is enabled and path is empty #38625

m2-assistant bot opened this issue Apr 16, 2024 · 2 comments · May be fixed by #38616
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2024

This issue is automatically created based on existing pull request: #38616: User is not redirected when use_store is enabled and path is empty


Description (*)

When the setting use store code in url is enabled, and the setting redirect to base url is enabled, the end-user is not redirected to base url with store code in path if the request url has an empty path. It's because in the store::baseUrl method, the web type doesn't add the store code, while link type does.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Apr 16, 2024
@m2-community-project m2-community-project bot added Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. labels Apr 16, 2024
@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Apr 16, 2024
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Apr 16, 2024
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Apr 16, 2024
@engcom-Delta engcom-Delta self-assigned this Apr 18, 2024
Copy link
Author

m2-assistant bot commented Apr 18, 2024

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta engcom-Delta added the Issue: needs update Additional information is require, waiting for response label Apr 19, 2024
@engcom-Delta
Copy link
Contributor

engcom-Delta commented Apr 19, 2024

Hi @thomas-kl1 ,

Thanks for your reporting and collaboration.

We have followed the steps as you mentioned and tried to reproduce this on 2.4-develop. However, we are not able to reproduce the same.

It would be helpful if you could provide more details with few screenshot so we can check this further.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
Low Priority Backlog
  
Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

3 participants