Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error "Please correct the target currency" when switching store with different currency than default one on GraphQl #38732

Closed
2 of 5 tasks
aelmizeb opened this issue May 16, 2024 · 4 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.7 Indicates original Magento version for the Issue report.

Comments

@aelmizeb
Copy link

aelmizeb commented May 16, 2024

Preconditions and environment

  • Magento 2.4.7
  • Issue seems to be related to [GraphQL] Store validation executes after defining current store #31336 exactly on the following function :
    magento changes
    The currency validation is done before set the current store in the context, then, the first GraphQL request will try to check the currency with the default store currency.
  • Also, now, these validations are executed two times: one in vendor/magento/module-graph-ql/Controller/GraphQl.php line 192 and in vendor/magento/module-graph-ql-cache/Controller/Plugin/GraphQl.php in beforeDispatch function

Steps to reproduce

  1. In storefront using GraphQl, switch the store to an other with a different currency than default store
  2. Check logs

Expected result

No error on logs

Actual result

Logs contains :
"message":"Please correct the target currency"

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented May 16, 2024

Hi @aelmizeb. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented May 16, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7 Indicates original Magento version for the Issue report. label May 16, 2024
@engcom-Bravo
Copy link
Contributor

Hi @aelmizeb,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

  • In storefront using GraphQl, switch the store to an other with a different currency than default store
  • Check logs
Screenshot 2024-05-21 at 15 19 48 Screenshot 2024-05-21 at 15 19 53 Screenshot 2024-05-21 at 15 22 25

Could you please provide us the mutation and also provide screenshots it will helps us to proceed further and please let us know if we are missing anything.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label May 21, 2024
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board May 21, 2024
@engcom-Bravo
Copy link
Contributor

Hi @aelmizeb,

We have noticed that this issue has not been updated since long time.
Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.7 Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

2 participants