-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Cannot return null for non-nullable field "SelectedShippingMethod.carrier_code" #38735
Comments
Hi @ThomasHWeb. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
Hi @engcom-Delta. Thank you for working on this issue.
|
Hi @ThomasHWeb , Thanks for reporting and collaboration. Verified the issue in magento 2.4.7 instance and the issue is not reproducible. Steps to reproduce:- 1.Send a Graphql query and verify query { We are not getting any error while sending the graphql query, ![]() Please add some more details with screenshots to debug this issue. Thanks, |
Hi @ThomasHWeb , Awaiting your reply to move further on this issue. Thanks, |
Hello @ThomasHWeb , As there is no activity on this issue for a long time, we believe the issue has been resolved, hence closing this issue. Thank you. |
Preconditions and environment
It triggers because of the changes made in vendor/magento/module-quote-graph-ql/Model/Resolver/ShippingAddress/SelectedShippingMethod.php related to this commit [2.4.5] Incorrect carrier/method code on selected shipping method in GraphQL #36606.
Somehow, the shipping method from address has not been reset before, and the rate associate is not in the rates list.
$carrierCode
and$methodCode
variables remain null after the foreach block.Steps to reproduce
Not able to reproduce it in my local environment. It seems to be a very tricky use case.
Expected result
To not have selected address if last shipping method saved not matched with the new rates list.
Actual result
Cart GraphQL data are not returned in storefront because of this error.
Additional information
No response
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: