Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShipmentTracking.title shall not be non-nullable #38743

Open
jbruni opened this issue May 21, 2024 · 5 comments
Open

ShipmentTracking.title shall not be non-nullable #38743

jbruni opened this issue May 21, 2024 · 5 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@jbruni
Copy link

jbruni commented May 21, 2024

Guys... look at this:

title: String! @doc(description: "The shipment tracking title.")

This shouldn't be "non-nullable", because:

  • Nothing in the admin prevents from submitting a shipment with empty (null) title. It is not a required field.
  • When we query a shipment with empty (null) title through GraphQL, it results in an error:
    "errors": [
        {
            "message": "Internal server error",
            "locations": [
                {
                    "line": 1,
                    "column": 704
                }
            ],
            "path": [
                "customer",
                "orders",
                "items",
                0,
                "shipments",
                0,
                "tracking",
                0,
                "title"
            ],
            "extensions": {
                "debugMessage": "Cannot return null for non-nullable field \"ShipmentTracking.title\"."
            }
        }
    ]

In order to fix this bug locally, I had to overwrite the GraphQL schema definition for ShipmentTracking.title field, making it nullable:

type ShipmentTracking @doc(description: "Contains order shipment tracking details.") {
    title: String @doc(description: "The shipment tracking title.")
}

Please make it nullable so it works for everyone without the need to override.

Thanks!

Copy link

m2-assistant bot commented May 21, 2024

Hi @jbruni. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented May 21, 2024

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash engcom-Dash removed their assignment May 21, 2024
@engcom-Delta engcom-Delta self-assigned this May 21, 2024
Copy link

m2-assistant bot commented May 21, 2024

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

Hi @jbruni ,

Thank you for your reporting and collaboration.

We have tried to reproduce the issue on 2.4-develop but we couldn't reproduce this.

Can you provide us the mutation used in graphql to reproduce the issue.

Thanks,

@engcom-Delta engcom-Delta added the Issue: needs update Additional information is require, waiting for response label May 23, 2024
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board May 23, 2024
@engcom-Delta engcom-Delta added Issue: ready for confirmation Reported on 2.4.x Indicates original Magento version for the Issue report. labels May 23, 2024
@m2-community-project m2-community-project bot moved this from Needs Update to Ready for Confirmation in Issue Confirmation and Triage Board May 23, 2024
@m2-community-project m2-community-project bot added Issue: ready for confirmation and removed Issue: ready for confirmation Issue: needs update Additional information is require, waiting for response labels May 23, 2024
@engcom-Delta engcom-Delta added the Issue: needs update Additional information is require, waiting for response label May 23, 2024
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board May 23, 2024
@engcom-Delta
Copy link
Contributor

Hi @jbruni ,

Awaiting your reply to move further on this issue.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
Development

No branches or pull requests

3 participants