Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.1.0-rc1 Utilise Catalog module's major version bump #4749

Closed
fooman opened this issue May 27, 2016 · 2 comments
Closed

2.1.0-rc1 Utilise Catalog module's major version bump #4749

fooman opened this issue May 27, 2016 · 2 comments
Assignees
@voleye

Comments

@fooman
Copy link
Contributor

fooman commented May 27, 2016

This commit here 90f4dec tries to prevent a breaking change for the Catalog module. It does so by directly using the ObjectManager instead of using proper Dependency Injection hiding away the dependencies essentially writing worse code.

Since we have a breaking change in the Catalog module any way due to https://github.com/magento/magento2/blob/2.1/app/code/Magento/Catalog/Api/ProductCustomOptionRepositoryInterface.php - so can we please also get the original implementation of 90f4dec
@fooman fooman changed the title 2.1.0-rc1 Utitlise Catalog module's major version bump 2.1.0-rc1 Utilise Catalog module's major version bump May 27, 2016
This was referenced May 27, 2016
Closed
Closed
@duhon duhon added the MX label Jun 9, 2016
@duhon duhon added TECH and removed TECH labels Jun 9, 2016
@fooman
Copy link
Contributor Author

fooman commented Jun 16, 2016 •
edited
Loading

I am guessing this is not happening RC3 with even more direct usage of the object manager - 8e58508#diff-8f628aca091b03b13df23d961bdded9fR83

583eeda

@fooman
Copy link
Contributor Author

fooman commented Jun 23, 2016

Did not happen https://github.com/magento/magento2/blob/2.1.0/app/code/Magento/Catalog/Controller/Adminhtml/Category/Edit.php#L118

@fooman fooman closed this as completed Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voleye voleye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duhon @fooman @voleye