Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart Price Rules: Category selection UI for Conditions do not come up. #6396

Closed
apurv-anand opened this issue Aug 30, 2016 · 11 comments
Closed
Labels
bug report Component: Tax Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update

Comments

@apurv-anand
Copy link

apurv-anand commented Aug 30, 2016

M2.1.0
Cart Price Rules: Category selection UI for Conditions do not come up.

Issue
Category selection UI under Conditions does not come up if a rule needs to be edited. The UI will come up only for 1st time. If the rule is saved, and is revisited for editing, the Category selection tree UI wont show up.

Steps:

  • Go to marketing > cart price rules.
  • Create a rule, with few categories selected under Conditions.
  • Save... come out.
  • Go back and edit the rule. Go to to edit the categories.

The categories UI does not pop up again. Clicking on the button does not do anything.

Workaround: Remove all the categories id and the button might work again.

Expected: The category selection UI should properly come up every time the rule is edited.

Ver: M2.1.0

@veloraven
Copy link
Contributor

@apurv-anand thank you for your feedback.
Please, format this issue according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result.

@apurv-anand apurv-anand changed the title Cart Price Rules: Category selection for conditions and actions - UI issue. Cart Price Rules: Category selection UI for Conditions do not come up. Aug 31, 2016
@apurv-anand
Copy link
Author

The requested steps are provided. Please update and accept the bug.

@sevos1984
Copy link
Contributor

This was fixed in 17788dc, ensure you have this code and also refresh your static files as well as browser cache.

@apurv-anand
Copy link
Author

This is NOT fixed in 2.1.1. The same behavior is now seen under Actions category selection as well.

@Ctucker9233
Copy link

Seems to be fixed in 2.1.1 for me.

@RomanKrut
Copy link

@apurv-anand Unfortunately, I could not reproduce the issue as you described it. Can you reproduce this issue on latest version of Magento2?

@koenner01
Copy link
Contributor

2.1.7 still contains this bug; @apurv-anand fix you are describing is present in 2.1.7 and not working.

Steps to reproduce:

  • Create price rule with condition 'category is one of ...'
  • Save the rule
  • Re-open the rule and try to change the category id value

@RomanKrut
Copy link

@koenner01 Thank you for your comment, Internal ticket was created MAGETWO-70129.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 23, 2017
@koenner01
Copy link
Contributor

koenner01 commented Jun 23, 2017

The problem seems to be a javascript problem, if I check an unchecked value on an existing condition I get:

Uncaught ReferenceError: catalog_rule_form is not defined
    at Ext.tree.TreePanel.Enhanced.eval (eval at <anonymous> (legacy-build.min.js:1), <anonymous>:156:9)
    at Ext.util.Event.fire (ext-tree.js:29)
    at Ext.tree.TreePanel.Enhanced.fireEvent (ext-tree.js:29)
    at Ext.tree.CheckboxNodeUI.check (ext-tree-checkbox.js:193)
    at El.Flyweight.<anonymous> (ext-tree.js:9)
    at HTMLInputElement.h (ext-tree.js:33)
    at HTMLInputElement.M (legacy-build.min.js:8)

@koenner01
Copy link
Contributor

Commits on MAGETWO-43350 might have a potential fix (haven't tried it yet)

@magento-team magento-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Jul 31, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-70345

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Progress: needs update Component: Tax labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Tax Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update
Projects
None yet
Development

No branches or pull requests

9 participants