Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Issue with a lot of configurable with lots of images #6979

Closed
paales opened this issue Oct 12, 2016 · 3 comments
Closed

Performance: Issue with a lot of configurable with lots of images #6979

paales opened this issue Oct 12, 2016 · 3 comments
Labels
bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Partner: Reach Digital Pull Request is created by partner Reach Digital

Comments

@paales
Copy link
Contributor

paales commented Oct 12, 2016

Preconditions

  1. 2.1.2

Steps to reproduce

  1. Create a lot of configurables with simples with images.
  2. Load a category page.

Expected result

  1. Loads only the media gallery images required and doesn't spend more than a second per query on the media gallery images.

Actual result

  1. Loads all images and spends about a second per query, resulting in 20000ms added to the page load.

Below the following line:

$select = $this->getMediaGalleryResource()->createBatchBaseSelect(
$this->getStoreId(),
$attribute->getAttributeId()
);

Add

$select->where('entity.entity_id IN(?)', $this->getLoadedIds());
@choukalos
Copy link

choukalos commented Oct 13, 2016

Tracking internally as MAGETWO-59138

@paales paales changed the title Performance issue with a lot of configurable with lots of images Performance: Issue with a lot of configurable with lots of images Oct 14, 2016
@kandy
Copy link
Contributor

kandy commented Oct 17, 2016

Duplicate #6850

@kandy kandy closed this as completed Oct 17, 2016
@paales
Copy link
Contributor Author

paales commented Oct 17, 2016

@kandy Thanks for the reference!

@paales paales added the Partner: Reach Digital Pull Request is created by partner Reach Digital label May 8, 2018
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Partner: Reach Digital Pull Request is created by partner Reach Digital
Projects
None yet
Development

No branches or pull requests

5 participants