Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not translate "Track All Shipments" in My Account, view order #9078

Closed
tagesjump opened this issue Mar 31, 2017 · 3 comments
Closed

Does not translate "Track All Shipments" in My Account, view order #9078

tagesjump opened this issue Mar 31, 2017 · 3 comments
Labels
bug report Component: Shipping Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Milestone

Comments

@tagesjump
Copy link

Preconditions

Does not translate "Track All Shipments" in My Account, view order

Steps to reproduce

  1. create order as client
  2. create shipment and add track number
  3. go to the my account
  4. open order view and chose tab Order Shipments

Expected result

  1. Translated phrase "Track All Shipments"

Reason: No call to the translation function

  1. module-shipping/view/frontend/layout/sales_order_shipment.xml
 <block class="Magento\Shipping\Block\Tracking\Link" name="track-all-link" template="tracking/link.phtml">
     <arguments>
           <argument name="label" xsi:type="string">Track All Shipments</argument>
      </arguments>
</block>
  1. module-shipping/view/frontend/templates/tracking/link.phtml
<?php /** @var $block \Magento\Shipping\Block\Tracking\Link */ ?>
<?php $order = $block->getOrder() ?>
<a href="#" class="action track" title="<?php /* @escapeNotVerified */ echo $block->getLabel() ?>"
   data-mage-init='{"popupWindow": {"windowURL":"<?php /* @escapeNotVerified */ echo $block->getWindowUrl($order) ?>","windowName":"trackorder","width":800,"height":600,"left":0,"top":0,"resizable":1,"scrollbars":1}}'>
    <span><?php /* @escapeNotVerified */ echo $block->getLabel()?></span>
</a>

@mrkhoa99
Copy link
Contributor

mrkhoa99 commented Apr 2, 2017

@tagesjump you can prefer to this pull request: #9095

@okorshenko
Copy link
Contributor

@tagesjump thank you for reporting the issue!
@mrkhoa99 thank you for fixing the issue!

@okorshenko okorshenko added this to the April 2017 milestone Apr 11, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-67053

@magento-team magento-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report develop Component: Shipping labels Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Shipping Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

4 participants