Skip to content

Commit

Permalink
FIX error while adding new user
Browse files Browse the repository at this point in the history
  • Loading branch information
phoenix128 committed Feb 19, 2018
1 parent 9aaa6a2 commit 50c9617
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 8 deletions.
22 changes: 18 additions & 4 deletions Ui/Component/Form/User/DataProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,29 @@ private function getTrustedDevices(User $user)
return $res;
}

/**
* @inheritdoc
*/
public function getMeta()
{
$meta = parent::getMeta();

$meta['base_fieldset']['children']['msp_tfa_providers']['arguments']['data']['config']['forced_providers'] =
$this->getForcedProviders();
$meta['base_fieldset']['children']['msp_tfa_providers']['arguments']['data']['config']['enabled_providers'] =
$this->enabledProvider->toOptionArray();

return $meta;
}

/**
* @inheritdoc
*/
public function getData()
{
if ($this->loadedData === null) {
$this->loadedData = [];
$items = $this->collection->getItems();
$forcedProviders = $this->getForcedProviders();
$enabledProviders = $this->enabledProvider->toOptionArray();

/** @var User $user */
foreach ($items as $user) {
Expand All @@ -173,8 +189,6 @@ public function getData()
$trustedDevices = $this->getTrustedDevices($user);

$data = [
'forced_providers' => $forcedProviders,
'enabled_providers' => $enabledProviders,
'reset_providers' => $resetProviders,
'trusted_devices' => $trustedDevices,
'msp_tfa_providers' => $providerCodes,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
<item name="namespace" xsi:type="string">msp_twofactorauth_edit_user_form</item>
</item>
<item name="template" xsi:type="string">templates/form/collapsible</item>
<item name="childrenFromMeta" xsi:type="boolean">true</item>
</argument>

<dataSource name="msp_twofactorauth_edit_user_form_data_source">
Expand Down
4 changes: 2 additions & 2 deletions view/adminhtml/web/js/form/element/providers.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ define(['Magento_Ui/js/form/element/abstract'], function (Abstract) {
* @returns {Array}
*/
getForcedProviders: function () {
return this.source.data['forced_providers'];
return this.forced_providers;
},

/**
* Get a list of enabled providers
* @returns {Array}
*/
getEnabledProviders: function () {
return this.source.data['enabled_providers'];
return this.enabled_providers;
},

/**
Expand Down
2 changes: 1 addition & 1 deletion view/adminhtml/web/js/form/element/reset_providers.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ define([
* @returns {Array}
*/
getResetProviders: function () {
return this.source.data['reset_providers'];
return this.source.data['reset_providers'] ? this.source.data['reset_providers'] : [];
},

/**
Expand Down
2 changes: 1 addition & 1 deletion view/adminhtml/web/js/form/element/trusted_devices.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ define([
* @returns {Array}
*/
getTrustedDevices: function () {
return this.source.data['trusted_devices'];
return this.source.data['trusted_devices'] ? this.source.data['trusted_devices'] : [];
},

/**
Expand Down

0 comments on commit 50c9617

Please sign in to comment.