Fix selection of configurable attributes not propagating #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting the product's options (for configurable products with no swatches), we should then dispatch a "change" and "input" events. This is implemented here in Puppeteer : https://github.com/puppeteer/puppeteer/blob/dd470c7a226a8422a938a7b0fffa58ffc6b78512/src/common/JSHandle.ts#L597 You can also find more info here : puppeteer/puppeteer#613 (comment)
leeroybrun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting the product's options (for configurable products with no swatches), we should then dispatch a "change" and "input" events.
This is implemented here in Puppeteer : https://github.com/puppeteer/puppeteer/blob/dd470c7a226a8422a938a7b0fffa58ffc6b78512/src/common/JSHandle.ts#L597
You can also find more info here : puppeteer/puppeteer#613 (comment)
When a product has multiple attributes, we need to select the first attribute option for Magento to fill the other attributes' options. If the "change" event is not fired, the next attribute's options are not loaded, and so we cannot select them and we cannot add the product to the cart.