Skip to content

Commit

Permalink
Alter saveWithBlock: so that it runs asynchronously. Fixes #349.
Browse files Browse the repository at this point in the history
  • Loading branch information
tonyarnold committed Jan 1, 2013
1 parent ec82bfc commit 357b62e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 24 deletions.
2 changes: 1 addition & 1 deletion MagicalRecord/Core/MagicalRecord+Actions.m
Expand Up @@ -15,7 +15,7 @@ @implementation MagicalRecord (Actions)

+ (void) saveWithBlock:(void(^)(NSManagedObjectContext *localContext))block;
{
[self saveWithBlockAndWait:block];
[self saveWithBlock:block completion:nil];
}

+ (void) saveWithBlock:(void(^)(NSManagedObjectContext *localContext))block completion:(MRSaveCompletionHandler)completion;
Expand Down
23 changes: 0 additions & 23 deletions Project Files/Mac Unit Tests/MagicalRecord+ActionsSpec.m
Expand Up @@ -148,29 +148,6 @@
#pragma clang diagnostic ignored "-Wdeprecated-declarations"

context(@"deprecated method", ^{
context(@"saveWithBlock:", ^{
it(@"should save", ^{
__block NSManagedObjectID *objectId;

[MagicalRecord saveWithBlock:^(NSManagedObjectContext *localContext) {
NSManagedObject *inserted = [SingleEntityWithNoRelationships MR_createInContext:localContext];

[[@([inserted hasChanges]) should] beTrue];

[localContext obtainPermanentIDsForObjects:@[inserted] error:nil];
objectId = [inserted objectID];
}];

[[objectId should] beNonNil];

NSManagedObject *fetchedObject = [[NSManagedObjectContext MR_rootSavingContext] objectRegisteredForID:objectId];

[[objectId should] beNonNil];
[[fetchedObject should] beNonNil];
[[@([fetchedObject hasChanges]) should] beFalse];
});
});

context(@"saveInBackgroundWithBlock:", ^{
it(@"should save", ^{
__block NSManagedObjectID *objectId;
Expand Down

0 comments on commit 357b62e

Please sign in to comment.