Add formal protocols and implementation definitions to avoid undeclar…

…ed selectors
magicalpanda · Jan 1, 2014 · 36411f0 · 36411f0
1 parent f5a1edc
commit 36411f0
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 5 deletions.
diff --git a/MagicalRecord.xcodeproj/project.pbxproj b/MagicalRecord.xcodeproj/project.pbxproj
@@ -1275,7 +1275,7 @@
 				GCC_WARN_SHADOW = YES;
 				GCC_WARN_SIGN_COMPARE = YES;
 				GCC_WARN_STRICT_SELECTOR_MATCH = YES;
-				GCC_WARN_UNDECLARED_SELECTOR = NO;
+				GCC_WARN_UNDECLARED_SELECTOR = YES;
 				GCC_WARN_UNINITIALIZED_AUTOS = YES;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_LABEL = YES;
@@ -1304,7 +1304,7 @@
 				GCC_WARN_SHADOW = YES;
 				GCC_WARN_SIGN_COMPARE = YES;
 				GCC_WARN_STRICT_SELECTOR_MATCH = YES;
-				GCC_WARN_UNDECLARED_SELECTOR = NO;
+				GCC_WARN_UNDECLARED_SELECTOR = YES;
 				GCC_WARN_UNINITIALIZED_AUTOS = YES;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_LABEL = YES;

diff --git a/MagicalRecord/Categories/NSManagedObject/NSManagedObject+MagicalRecord.h b/MagicalRecord/Categories/NSManagedObject/NSManagedObject+MagicalRecord.h
@@ -48,3 +48,10 @@
 
 @end
 
+@protocol MagicalRecord_MOGenerator <NSObject>
+
+@optional
+- (instancetype) entityInManagedObjectContext:(NSManagedObjectContext *)object;
+- (instancetype) insertInManagedObjectContext:(NSManagedObjectContext *)object;
+
+@end
diff --git a/Tests/DataImport/MagicalDataImportTestCase.h b/Tests/DataImport/MagicalDataImportTestCase.h
@@ -14,5 +14,6 @@
 @property (nonatomic, strong) id testEntity;
 
 - (Class) testEntityClass;
+- (void) setupTestData;
 
 @end
diff --git a/Tests/DataImport/MagicalDataImportTestCase.m b/Tests/DataImport/MagicalDataImportTestCase.m
@@ -21,9 +21,7 @@ - (void)setUp
     [MagicalRecord setDefaultModelFromClass:[self class]];
     [MagicalRecord setupCoreDataStackWithInMemoryStore];
 
-    if ([self respondsToSelector:@selector(setupTestData)]) {
-        [self performSelector:@selector(setupTestData)];
-    }
+    [self setupTestData];
 
     self.testEntityData = [self dataFromJSONFixture];
 }
@@ -40,4 +38,9 @@ - (Class)testEntityClass;
     return [NSManagedObject class];
 }
 
+- (void)setupTestData
+{
+    // Implement this in your subclasses
+}
+
 @end