Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spelling for release/3.0 branch #1061

Merged
merged 2 commits into from
Aug 17, 2015
Merged

Conversation

Coeur
Copy link
Collaborator

@Coeur Coeur commented Aug 16, 2015

No description provided.

@@ -43,7 +43,8 @@
*/
+ (NSURL *) MR_fileURLForStoreNameIfExistsOnDisk:(NSString *)storeFileName;

+ (NSURL *) MR_cloudURLForUbiqutiousContainer:(NSString *)bucketName;
+ (NSURL *) MR_cloudURLForUbiquitousContainer:(NSString *)bucketName;
+ (NSURL *) MR_cloudURLForUbiqutiousContainer:(NSString *)bucketName __deprecated;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same again — please use the macros that have been setup for this purpose: MR_DEPRECATED_WILL_BE_REMOVED_IN_PLEASE_USE("MR_cloudURLForUbiquitousContainer:") will tell the user what they need to use instead of the deprecated method.

@Coeur
Copy link
Collaborator Author

Coeur commented Aug 17, 2015

added MR_DEPRECATED_WILL_BE_REMOVED_IN_PLEASE_USE

@tonyarnold tonyarnold added the Bug label Aug 17, 2015
@tonyarnold tonyarnold added this to the 3.0.0 milestone Aug 17, 2015
@tonyarnold tonyarnold self-assigned this Aug 17, 2015
tonyarnold added a commit that referenced this pull request Aug 17, 2015
Spelling fixes in comments and method names
@tonyarnold tonyarnold merged commit c85ab16 into magicalpanda:release/3.0 Aug 17, 2015
@tonyarnold
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants