Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MagicalRecord.podspec #1101

Merged
merged 2 commits into from
Oct 21, 2015
Merged

Update MagicalRecord.podspec #1101

merged 2 commits into from
Oct 21, 2015

Conversation

melbic
Copy link
Contributor

@melbic melbic commented Sep 30, 2015

Fixing Issue: #988

I didn't test what happens if CocoaLumberjack wasn't used in a project...

@tonyarnold
Copy link
Contributor

I didn't test what happens if CocoaLumberjack wasn't used in a project...

Any chance that you could? I'm not going to have time to test this for a week or so.

@melbic
Copy link
Contributor Author

melbic commented Sep 30, 2015

I don't know if I'll find time for it this week, but I'll try.

@melbic
Copy link
Contributor Author

melbic commented Sep 30, 2015

Sometimes you have to take the time. But it actually doesn't work. It fails with:

ld: framework not found CocoaLumberJack
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I didn't find a way to add the framework as optional.

@tonyarnold
Copy link
Contributor

What I'd say we have to do is add a "MagicalRecord+CocoaLumberjack" subspec that users can chose to use over the standard "MagicalRecord" one. That subspec could link in CL.

@melbic
Copy link
Contributor Author

melbic commented Sep 30, 2015

I added a Subspec, so the version with CocoaLumberjack as dependency can be installed with:
pod "MagicalRecord/CocoaLumberjack"

@scottrhoyt
Copy link

Can we get this pulled? I think there's a few of us waiting on this one. Thanks!

tonyarnold added a commit that referenced this pull request Oct 21, 2015
Update podspec to include CocoaLumberjack subspec
@tonyarnold tonyarnold merged commit 79ebd10 into magicalpanda:master Oct 21, 2015
@bpoplauschi
Copy link

This update should be propagated to the CocoaPods/Specs repo so we all get it.

@lolgear
Copy link

lolgear commented Nov 10, 2015

done?

@bpoplauschi
Copy link

Guys, you need to make this update to Cocoapods/Specs. We cannot make it. Apparently, only Saul Mora and Tony Arnold can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants