MR_fetchAllGroupedBy method performs double fetch

[yvbeek]

The MR_fetchAllGroupedBy method already performs a fetch. The extra fetch command was causing a double fetch.

Issue: #410

[tonyarnold]

Hi @Zyphrax — two quick things:

1. Is there are reason you can't remove the performFetch: in your code? I can see an argument for keeping this in and keeping it simple, but I hesitate to make a change that might break other's use of the method you're modifying;
2. Can you resubmit this request against the develop branch, please? We avoid committing/merging directly to master;

[yvbeek]

@tonyarnold : I've replaced the code in my local solution, but I have to keep in mind to make this change whenever I update my MR pod. I thought the pull request would be usefull because it looks like a bug. I don't see why you would ever want the two fetches to occur directly after one and other, seems like wasting performance. As you can see the code change is minor, to reduce two fetches to one (in line with the other methods).

I don't see how this would break user code. The fetch still happens, only no longer twice in MR code.

I'll have a look if I can make another pull request for the development branch. I'm not that familiar with GitHub yet :)

[tonyarnold]

Hi @Zyphrax — thanks for responding. You're right — I don't know how I didn't see this one the first time around. I'll merge the change in unless you'd like your name to appear in the commit logs. Let me know!

[yvbeek]

Hi @tonyarnold feel free to merge the change. I'm very grateful for this great framework, I was just happy to help.