Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Implement Versioned Transactions #44

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

GabrielePicco
Copy link
Contributor

@GabrielePicco GabrielePicco commented Sep 12, 2023

Implement Versioned Transactions

Status Type ⚠️ Core Change Issue
Ready Feature Yes #43

Problem

Solution

  • Added a VersionedTransaction class which can serialize/deserialize Versioned Transactions, implemented following web3.js implementation
  • VersionedTransaction contains the AddressTableLookups
  • Transaction.Deserialize use the prefix byte to auto-detected if the transaction is legacy or versioned and uses the correct implementation

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6153600844

  • 221 of 253 (87.35%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 73.68%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Solana.Unity.Rpc/Models/Message.cs 3 5 60.0%
src/Solana.Unity.Rpc/Models/VersionedMessage.cs 102 110 92.73%
src/Solana.Unity.Rpc/Models/VersionedTransaction.cs 54 64 84.38%
src/Solana.Unity.Rpc/Builders/VersionedMessageBuilder.cs 55 67 82.09%
Files with Coverage Reduction New Missed Lines %
src/Solana.Unity.Rpc/Core/Http/CrossHttpClient.cs 1 9.38%
Totals Coverage Status
Change from base Build 5926307434: 0.6%
Covered Lines: 4982
Relevant Lines: 6466

💛 - Coveralls

@GabrielePicco GabrielePicco merged commit 1fdfb7c into master Sep 12, 2023
1 check passed
@GabrielePicco GabrielePicco deleted the feat/versioned-transactions branch September 12, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants